8253597: TreeTableView: must select leaf row on click into indentation region

[kleopatra]

.. but doesn't reliably (see report for details). Fixed in TreeTableCellBehavior to check for visibility of the disclosureNode.

Added test that failed before and passes after, along with a couple of sanity tests.

Also added an alternative mouseEvent creation path into MouseEventFirer (and test) to work-around JDK-8253769

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253597: TreeTableView: must select leaf row on click into indentation region

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/313/head:pull/313
$ git checkout pull/313

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (d06812e)
• 00: Full (0fe1ca4)

[kevinrushforth]

@aghaisas can you review this? A single reviewer should be sufficient, but if you think it needs a second reviewer, go ahead and indicate that.

[aghaisas]

Looks good.
I spotted a typo.

[aghaisas]

coordiate --> coordinate

[kleopatra]

thanks for spotting it - there's always at least one ;) Fixed.

[openjdk]

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253597: TreeTableView: must select leaf row on click into indentation region

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 205e4b9: 8178297: TableView scrolls slightly when adding new elements
• a56ba63: 8254255: Remove obsolete .hgignore file
• 184f12c: 8252192: Update to Visual Studio 2019 version 16.7.2
• 7857022: 8251946: ObservableList.setAll does not conform to specification
• 1c485a3: 8252191: Update to gcc 10.2 on Linux
• 15e52d8: 8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15
• 5b42b64: 8252236: TabPane: must keep header of selected tab visible

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

@kleopatra Since your change was applied there have been 7 commits pushed to the master branch:

• 205e4b9: 8178297: TableView scrolls slightly when adding new elements
• a56ba63: 8254255: Remove obsolete .hgignore file
• 184f12c: 8252192: Update to Visual Studio 2019 version 16.7.2
• 7857022: 8251946: ObservableList.setAll does not conform to specification
• 1c485a3: 8252191: Update to gcc 10.2 on Linux
• 15e52d8: 8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15
• 5b42b64: 8252236: TabPane: must keep header of selected tab visible

Your commit was automatically rebased without conflicts.

Pushed as commit 00f5b7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.