Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253597: TreeTableView: must select leaf row on click into indentation region #313

Closed
wants to merge 2 commits into from

Conversation

@kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented Oct 2, 2020

.. but doesn't reliably (see report for details). Fixed in TreeTableCellBehavior to check for visibility of the disclosureNode.

Added test that failed before and passes after, along with a couple of sanity tests.

Also added an alternative mouseEvent creation path into MouseEventFirer (and test) to work-around JDK-8253769


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253597: TreeTableView: must select leaf row on click into indentation region

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/313/head:pull/313
$ git checkout pull/313

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 2, 2020

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 2, 2020

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 2, 2020

@aghaisas can you review this? A single reviewer should be sufficient, but if you think it needs a second reviewer, go ahead and indicate that.

@kevinrushforth kevinrushforth requested a review from aghaisas Oct 2, 2020
Copy link
Collaborator

@aghaisas aghaisas left a comment

Looks good.
I spotted a typo.

/**
* Fires a mouseEvent with the given configuration options onto the target.
* Hot-fix for JDK-8253769.
* The mouseEvent is created such that coordiate transformation constraints seem to be respected.
Copy link
Collaborator

@aghaisas aghaisas Oct 12, 2020

coordiate --> coordinate

Copy link
Collaborator Author

@kleopatra kleopatra Oct 12, 2020

thanks for spotting it - there's always at least one ;) Fixed.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253597: TreeTableView: must select leaf row on click into indentation region

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 205e4b9: 8178297: TableView scrolls slightly when adding new elements
  • a56ba63: 8254255: Remove obsolete .hgignore file
  • 184f12c: 8252192: Update to Visual Studio 2019 version 16.7.2
  • 7857022: 8251946: ObservableList.setAll does not conform to specification
  • 1c485a3: 8252191: Update to gcc 10.2 on Linux
  • 15e52d8: 8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15
  • 5b42b64: 8252236: TabPane: must keep header of selected tab visible

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 12, 2020
@kleopatra
Copy link
Collaborator Author

@kleopatra kleopatra commented Oct 12, 2020

/integrate

@openjdk openjdk bot closed this Oct 12, 2020
@openjdk openjdk bot added integrated and removed ready labels Oct 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@kleopatra Since your change was applied there have been 7 commits pushed to the master branch:

  • 205e4b9: 8178297: TableView scrolls slightly when adding new elements
  • a56ba63: 8254255: Remove obsolete .hgignore file
  • 184f12c: 8252192: Update to Visual Studio 2019 version 16.7.2
  • 7857022: 8251946: ObservableList.setAll does not conform to specification
  • 1c485a3: 8252191: Update to gcc 10.2 on Linux
  • 15e52d8: 8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15
  • 5b42b64: 8252236: TabPane: must keep header of selected tab visible

Your commit was automatically rebased without conflicts.

Pushed as commit 00f5b7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Oct 12, 2020
@kleopatra kleopatra deleted the bug-fix-8253597 branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants