-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15 #314
Conversation
👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think a single reviewer is sufficient, unless you want another pair of eyes on it.
@arun-joseph This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@arun-joseph Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 15e52d8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Issue: In JDK15, URLConnection class overrode the getHeaderFields() methods to return properties, which previously returned an empty map from its super class.
Fix: Extract headers only when it's a HttpURLConnection, otherwise return an empty String.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/314/head:pull/314
$ git checkout pull/314