Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15 #314

Closed
wants to merge 3 commits into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Oct 5, 2020

Issue: In JDK15, URLConnection class overrode the getHeaderFields() methods to return properties, which previously returned an empty map from its super class.

Fix: Extract headers only when it's a HttpURLConnection, otherwise return an empty String.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/314/head:pull/314
$ git checkout pull/314

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I think a single reviewer is sufficient, unless you want another pair of eyes on it.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@arun-Joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5b42b64: 8252236: TabPane: must keep header of selected tab visible
  • 77a183e: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 5, 2020
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Oct 6, 2020

/integrate

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@arun-Joseph Since your change was applied there have been 2 commits pushed to the master branch:

  • 5b42b64: 8252236: TabPane: must keep header of selected tab visible
  • 77a183e: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing

Your commit was automatically rebased without conflicts.

Pushed as commit 15e52d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arun-Joseph arun-Joseph deleted the 8253696 branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants