Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8130738: Add tabSize property to Text and TextFlow #32

Closed
wants to merge 7 commits into from

Conversation

@swpalmer
Copy link

swpalmer commented Nov 6, 2019

Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to both. TextFlow's tab size overrides that of contained Text nodes.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8130738: Add tabSize property to Text and TextFlow

Approvers

  • Phil Race (prr - Reviewer) Note! Review applies to f846ad6
  • Kevin Rushforth (kcr - Reviewer)
Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to both.  TextFlow's tab size overrides that of contained Text nodes.
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Nov 6, 2019

👋 Welcome back swpalmer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 6, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 6, 2019

Webrevs

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 7, 2019

Mailing list message from David Grieve David.Grieve@microsoft.com

What happens if you do text.tabSizeProperty().setValue(null) ?

-----Original Message-----
From: openjfx-dev On Behalf Of
Scott Palmer
Sent: Wednesday, November 6, 2019 11:12 AM
To: openjfx-dev at openjdk.java.net
Subject: RFR: 8130738: TextFlow's tab width is static

Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
both. TextFlow's tab size overrides that of contained Text nodes.


Commits:

  • 68d221c: 8130738: TextFlow's tab width is static

Changes:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.o
penjdk.java.net%2Fjfx%2Fpull%2F32%2Ffiles&data=02%7C01%7CDavid.
Grieve%40microsoft.com%7C6044739a564243b00a3b08d762edb49b%7C72f9
88bf86f141af91ab2d7cd011db47%7C1%7C0%7C637086645878076773&
sdata=ov9cwdWgDaJxX0waFCXv3ca0CStlZm39q%2FQMNt9X%2BQU%3D&am
p;reserved=0
Webrev:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwebr
evs.openjdk.java.net%2Fjfx%2F32%2Fwebrev.00&data=02%7C01%7CDa
vid.Grieve%40microsoft.com%7C6044739a564243b00a3b08d762edb49b%7C
72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637086645878076773&a
mp;sdata=00p7TljKs9FhkblloXDQhY74l4j3GqORzH%2ByRfwn40E%3D&re
served=0
Issue:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
.openjdk.java.net%2Fbrowse%2FJDK-
8130738&data=02%7C01%7CDavid.Grieve%40microsoft.com%7C604473
9a564243b00a3b08d762edb49b%7C72f988bf86f141af91ab2d7cd011db47%7
C1%7C0%7C637086645878076773&sdata=iZyZ5RTtfjzCd5bME%2Bpf3nA
OI%2BtE8sjJGkRMl%2BQdUL8%3D&reserved=0
Stats: 324 lines in 8 files changed: 260 ins; 0 del; 64 mod
Patch:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.o
penjdk.java.net%2Fjfx%2Fpull%2F32.diff&data=02%7C01%7CDavid.Grie
ve%40microsoft.com%7C6044739a564243b00a3b08d762edb49b%7C72f988b
f86f141af91ab2d7cd011db47%7C1%7C0%7C637086645878086767&sdat
a=L5BuXwvyCYwG%2BEb1hktl2ahXDPXgHkeFMLDthRSr2BY%3D&reserve
d=0
Fetch: git fetch
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.o
penjdk.java.net%2Fjfx&data=02%7C01%7CDavid.Grieve%40microsoft.co
m%7C6044739a564243b00a3b08d762edb49b%7C72f988bf86f141af91ab2d7c
d011db47%7C1%7C0%7C637086645878086767&sdata=waZ9DLUjPqyBv
kOrgJQDjtp6gp9Y8chyhVFlbsXplU0%3D&reserved=0
pull/32/head:pull/32

PR:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.o
penjdk.java.net%2Fjfx%2Fpull%2F32&data=02%7C01%7CDavid.Grieve%
40microsoft.com%7C6044739a564243b00a3b08d762edb49b%7C72f988bf86f
141af91ab2d7cd011db47%7C1%7C0%7C637086645878086767&sdata=G
kwyOTeBRFTdQnZ0Ovttf3vz7F4rkhrJZ9nT0pwUZrQ%3D&reserved=0

Fixed clamping so reads of tabSize give clamped value.
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 7, 2019

Mailing list message from Scott Palmer swpalmer@gmail.com

setValue(null) is interpreted as set(0) by IntegerProperty. This in turn will be clamped to 1 by the TextLayout. The property on the Text node will still read as 0.
So now that you mention it, I don?t like where the clamping is implemented. I should clamp so it reads back as 1 - Fixed.

Scott

On Nov 6, 2019, at 11:23 PM, David Grieve <David.Grieve at microsoft.com> wrote:

What happens if you do text.tabSizeProperty().setValue(null) ?

-----Original Message-----
From: openjfx-dev On Behalf Of
Scott Palmer
Sent: Wednesday, November 6, 2019 11:12 AM
To: openjfx-dev at openjdk.java.net
Subject: RFR: 8130738: TextFlow's tab width is static

Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
both. TextFlow's tab size overrides that of contained Text nodes.

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Nov 7, 2019

I should clamp so it reads back as 1 - Fixed.

This has implications for binding, etc., so I suspect this is not what we want. I'll look into this more when I review it.

NOTE: This will need a CSR in addition to two reviewers. You can file the CSR any time, but I suggest leaving it in Draft state until Phil and I have had a first pass look at the API.

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Nov 7, 2019

Mailing list message from Scott Palmer swpalmer@gmail.com

Yes, I suppose this should behave like anything else that uses an
IntegerProperty as far as bindings are concerned. I'll wait for further
review before reverting that last change. If tabSize=0 worked reasonably it
would be much simpler. I'm not sure if I will have the time to hunt down
why things go wrong in that case (everything after a tab appears at x
offset 0).

I've created the CSR, hopefully I did it correctly.
https://bugs.openjdk.java.net/browse/JDK-8233810

Scott

On Thu, Nov 7, 2019 at 9:57 AM Kevin Rushforth wrote:

On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer
wrote:

Added tabSize property to Text and TextFlow and -fx-tab-size CSS
attribute to both. TextFlow's tab size overrides that of contained Text
nodes.


Commits:

  • 68d221c: 8130738: TextFlow's tab width is static

Changes: https://git.openjdk.java.net/jfx/pull/32/files
Webrev: https://webrevs.openjdk.java.net/jfx/32/webrev.00
Issue: https://bugs.openjdk.java.net/browse/JDK-8130738
Stats: 324 lines in 8 files changed: 260 ins; 0 del; 64 mod
Patch: https://git.openjdk.java.net/jfx/pull/32.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/32/head:pull/32

I should clamp so it reads back as 1 - Fixed.

This has implications for binding, etc., so I suspect this is not what we
want. I'll look into this more when I review it.

NOTE: This will need a CSR in addition to two reviewers. You can file the
CSR any time, but I suggest leaving it in Draft state until Phil and I have
had a first pass look at the API.

PR: https://git.openjdk.java.net/jfx/pull/32

Copy link
Contributor

prrace left a comment

Why do we have a ton of extraneous white space changes in the Stylesheet Handling sections of Text.java and TextFlow.java ?

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Nov 26, 2019

The indenting was wrong in that section and I had to make some minor changes, so I corrected the bad indenting. Kevin indicated, "In your specific case, reformatting the methods in the StyleableProperties nested class that are adjacent to code you add or modify seems fine, as long as you only change the indentation and not the line wrapping."

I didn't intend to trigger an update to this pull request...I find Git awkward to work with (Mercurial makes more sense to me) so I'm making mistakes as I bumble around.

I do expect an update to address the way I've clamped to 1. I agree with Kevin that it is probable wrong. Just waiting for feedback.

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Nov 26, 2019

I'll take a preliminary look today. I also plan to change the bug title to make it more clear that it is an enhancement request, since it currently reads like a bug report (I'll also change the CSR and PR title to match).

@kevinrushforth kevinrushforth changed the title 8130738: TextFlow's tab width is static 8130738: Add tabSize property to Text and TextFlow Nov 27, 2019
Copy link
Collaborator

kevinrushforth left a comment

I did a first pass review focusing mostly on the public API. Once we get that solidified I'll look at the implementation and tests more closely. Also, once the public API is done, you can update the CSR with the API.

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Nov 27, 2019

I just noticed that Text.toString is missing any indication of the tabSize. (Found by accident when I search for wrappingWidth to see how the javadocs were done.)
Is there any rule as to where in the order of properties ", tabSize = X" should be in the string? I assume it should only be included when not set to the default value, much like lineSpacing?

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Nov 27, 2019

Yes, I think your idea of including tabSize in Text.toString when != default is a good one.

Addressed review comments:
- Backed out property value clamping
- Fixed javadocs and cssref
- Fixed and added tests
- Minor formatting
@tkslaw

This comment has been minimized.

Copy link

tkslaw commented Nov 27, 2019

Should this PR also add a tabSize property to controls such as TextArea? Or should that be a different PR after this one is merged?

Copy link
Collaborator

kevinrushforth left a comment

Overall this looks good to me with one "must fix" API issue and one additional minor comment.

In addition to the automated unit test, it might be nice to have a simple app (in apps/toys) with a slider to control the tab size of a Text and/or TextFlow. This could be done as a follow-on issue if you prefer.

Once you fix the public API issue, you can add ithe API to the CSR and I'll review it. The javadoc, public methods, and CSS additions for the two classes should go into the CSR in the specification section. See JDK-8195139 for a good example.

@prrace still needs to review the implementation and API as well.

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 10, 2019

Should this PR also add a tabSize property to controls such as TextArea? Or should that be a different PR after this one is merged?

This would need to be a new enhancement and would first need to be discussed on the openjfx-dev mailing list. There are additional things to consider in order to support tab size for controls, and it isn't clear whether there is enough benefit in doing it.

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 10, 2019

As a follow-on point to the missing public method in TextFlow, can you add unit tests for the API methods on both Text and TextFlow? A good way to do that is to have a test for all combinations of setting the value via the setter and the property method, and getting the value via the getter and the property method.

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 11, 2019

The unit tests that were already added to TextTest.java cover the new methods on Text, but not in every combination. I'll add a couple more to ensure all combinations are covered. TextFlow has no existing unit tests that I could find! Shall I add a new TextFlowText.java file for just these tests?

The apps/toys folder seems to use ant-based projects. The existing ones don't build for me. If I made a new project there could I use the JavaFX Gradle plugin and configure it to get JavaFX from the build/sdk folder?

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 11, 2019

I think a new TextFlowTest.java would be a good place for those tests.

Our build is set up to use ant so if you want to wire it up to the build, you'll need that (it should be as simple as having ANT_HOME set to apache-ant-1.10.5). It would be fine to defer this if you can't get it working.

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 12, 2019

I just noticed while updating the CSR that, while I mentioned it on the mailing list, the fact that TextFlow's tabSize override that of any contained Text nodes is not documented.
Shall I add to the javadoc for tabSize in TextFlow : "This value overrides the tabSize of contained Text nodes." ?

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 12, 2019

Good catch. Yes, please update it as you suggested.

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 12, 2019

The following comment from @swpalmer sent to the openjfx-dev mailing list wasn't mirrored in the PR (I have alerted the Skara team about this).


From: Scott Palmer

I think a new TextFlowTest.java would be a good place for those tests.

My first attempt at unit tests for TextFlow are failing. I believe the StubTextLayout is not equipped to handle TextFlow. This may be a bigger job…

This fragment triggers a NPE:
...
Toolkit tk = (StubToolkit) Toolkit.getToolkit();
HBox root = new HBox();
Scene scene = new Scene(root);
Stage stage = new Stage();
stage.setScene(scene);
stage.setWidth(300);
stage.setHeight(200);

    try {
        Text text1 = new Text("\tfirst");
        Text text2 = new Text("\tsecond");
        TextFlow textFlow = new TextFlow(text1, text2);
        root.getChildren().addAll(textFlow);
        stage.show();

...

test.javafx.scene.text.TextFlowTest > testTabSize FAILED
java.lang.NullPointerException
at test.com.sun.javafx.pgstub.StubTextLayout.getBounds(StubTextLayout.java:88)
at test.com.sun.javafx.pgstub.StubTextLayout.getBounds(StubTextLayout.java:82)
at javafx.graphics/javafx.scene.text.TextFlow.computePrefWidth(TextFlow.java:254)
at javafx.graphics/javafx.scene.Parent.prefWidth(Parent.java:1019)
at javafx.graphics/javafx.scene.layout.Region.prefWidth(Region.java:1543)
at javafx.graphics/javafx.scene.layout.Region.computeChildPrefAreaWidth(Region.java:1946)
at javafx.graphics/javafx.scene.layout.HBox.getAreaWidths(HBox.java:465)
at javafx.graphics/javafx.scene.layout.HBox.computeContentWidth(HBox.java:540)
at javafx.graphics/javafx.scene.layout.HBox.computePrefWidth(HBox.java:433)
at javafx.graphics/javafx.scene.Parent.prefWidth(Parent.java:1019)
at javafx.graphics/javafx.scene.layout.Region.prefWidth(Region.java:1543)
at javafx.graphics/javafx.scene.Scene.getPreferredWidth(Scene.java:1799)
at javafx.graphics/javafx.scene.Scene.resizeRootToPreferredSize(Scene.java:1779)
at javafx.graphics/javafx.scene.Scene.preferredSize(Scene.java:1747)
at javafx.graphics/javafx.scene.Scene$2.preferredSize(Scene.java:393)
at javafx.graphics/com.sun.javafx.scene.SceneHelper.preferredSize(SceneHelper.java:66)
at javafx.graphics/javafx.stage.Window$12.invalidated(Window.java:1086)
at javafx.base/javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)
at javafx.base/javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
at javafx.graphics/javafx.stage.Window.setShowing(Window.java:1174)
at javafx.graphics/javafx.stage.Window.show(Window.java:1189)
at javafx.graphics/javafx.stage.Stage.show(Stage.java:273)
at test.javafx.scene.text.TextFlowTest.testTabSize(TextFlowTest.java:60)

Scott

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 12, 2019

In that case, I recommend just doing the API get/set tests for TextFlow without creating a Scene or Stage. This won't need anything from the StubToolkit.

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 12, 2019

In my attempts to address the issue with StubTextLayout I discovered bugs. TextFlow is NOT properly overriding the tabSize of the Text nodes. If you set the Text node tab size later, the layout reacts and adjusts to the tabSize of the Text node even though it is contained in a TextFlow. Whichever node changes the tabSize last affects the layout. I'm going to have to study this more, but this change isn't ready at this point.

 - Fixed public property issue, improved tests
@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 19, 2019

I was thinking of deferring the apps/toys demo to avoid any delays in getting the new API into JavaFX 14. I have something for it, I just don't want any feedback on it to hold up the review of this issue. Is there anything else I need to do? Is the CSR in good shape?

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 20, 2019

I agree that that addition of a demo program in apps/toys can be decoupled from this. Please file a follow-up issue for this.

I reviewed the CSR. It looks ready to go.

In addition to an approved CSR, both @prrace and I will need to review this PR.

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 20, 2019

I have created https://bugs.openjdk.java.net/browse/JDK-8236438 to track the creation of a demo program.

@prrace
prrace approved these changes Dec 20, 2019
@openjdk openjdk bot removed the rfr label Dec 20, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Dec 20, 2019

@swpalmer This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8130738: Add tabSize property to Text and TextFlow

Reviewed-by: prr, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 19 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @kevinrushforth, @nlisker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 20, 2019
Copy link
Collaborator

kevinrushforth left a comment

The fix looks good now. There is one problem in the test (in StubTextLayout) that needs to be fixed.

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 21, 2019

Interesting. I was only running the tests in graphics (gradle :graphics:test) as when I run all the tests I always get this failure (unrelated to anything I've changed):

> Task :base:test

test.javafx.util.converter.LocalDateTimeStringConverterTest > toString_to_fromString_testRoundtrip[0] FAILED
    java.time.format.DateTimeParseException: Text '1985-01-12, 12:34 p.m.' could not be parsed, unparsed text found at index 19
        at java.base/java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:2052)
        at java.base/java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1877)
        at javafx.base/javafx.util.converter.LocalDateTimeStringConverter$LdtConverter.fromString(LocalDateTimeStringConverter.java:208)
        at javafx.base/javafx.util.converter.LocalDateTimeStringConverter.fromString(LocalDateTimeStringConverter.java:159)
        at test.javafx.util.converter.LocalDateTimeStringConverterTest.toString_to_fromString_testRoundtrip(LocalDateTimeStringConverterTest.java:131)

5222 tests completed, 1 failed, 27 skipped
@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 21, 2019

I'm not sure if I'me supposed to try to integrate now that I've made that 10 -> 0 change, or if the new change resets the need for review... Also, note that the link in the bot msg for "project specific requirements" is giving me a 404 error.

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Dec 21, 2019

Mailing list message from Philip Race on openjfx-dev:

On 12/20/19, 7:04 PM, Scott Palmer wrote:

I'm not sure if I'me supposed to try to integrate now that I've made that 10 -> 0 change, or if the new change resets the need for review...

It shows ready, which surprises me.
Still learning skara .. I'd expect any change to reset as how can it
know if it is
a good or insignificant change or not no matter how the commenter
characterised the issue ?

Also, note that the link in the bot msg for "project specific requirements" is giving me a 404 error.
I see that too https://github.com/openjdk/jfx/blob/masterCONTRIBUTING.md

I don't know how the change here :
https://github.com/openjdk/skara/pull/343/files

+ automated pre-integration checks. When the change also ");
+ message.append("fulfills all [project specific
requirements](https://github.com/");

maps to the project, but it seems like there's a config bug somewhere
that may be just being
exposed

-phil

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 21, 2019

Link problem appears to just be a missing slash: https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md

@prrace

This comment has been minimized.

Copy link
Contributor

prrace commented Dec 21, 2019

Link problem appears to just be a missing slash: https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md

Seems this was fixed yesterday : openjdk/skara#344

@swpalmer

This comment has been minimized.

Copy link
Author

swpalmer commented Dec 24, 2019

/integrate

@openjdk openjdk bot added the sponsor label Dec 24, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Dec 24, 2019

@swpalmer
Your change (at version 78ddf12) is now ready to be sponsored by a Committer.

@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 31, 2019

@swpalmer The change still needs my completed review -- note that there is currently only one reviewer listed in the Approvers section above. Once I approve, which I will do soon, I will sponsor it.

I'm still looking for ways to make the CONTRIBUTING guidelines more clear as to when it is OK to integrate. I'll take a stab at it in the new year...

Copy link
Collaborator

kevinrushforth left a comment

Looks good now.

@openjdk openjdk bot added ready and removed ready labels Dec 31, 2019
@kevinrushforth

This comment has been minimized.

Copy link
Collaborator

kevinrushforth commented Dec 31, 2019

/sponsor

@openjdk openjdk bot closed this Dec 31, 2019
@openjdk openjdk bot added integrated and removed sponsor ready labels Dec 31, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Dec 31, 2019

@kevinrushforth @swpalmer The following commits have been pushed to master since your change was applied:

  • 69e4ef3: 8235627: Blank stages when running JavaFX app in a macOS virtual machine
  • 5e0fb91: 8235364: Update copyright header for files modified in 2019
  • 935e99d: 8207957: TableSkinUtils should not contain actual code implementation
  • 4e005e4: 8227808: Make GTK3 libraries mandatory for building on Linux
  • 1140d34: 8196587: Remove use of deprecated finalize method from JPEGImageLoader
  • d2d44b4: 8207759: VK_ENTER not consumed by TextField when default Button exists
  • fc539b5: 8223296: NullPointerException in GlassScene.java at line 325
  • 71ca899: 8220722: ProgressBarSkin: adds strong listener to control's width property
  • 07af89a: 8221334: TableViewSkin: must initialize flow's cellCount in constructor
  • 4ddf554: 8234916: [macos 10.15] Garbled text running with native-image
  • 46338d0: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
  • a68347c: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
  • 1c27fbd: 8210955: DOMTest::testEventListenerCascade fails
  • 2d4096a: 8235151: Nonexistent notifyQuit method referred from iOS GlassHelper.m
  • 98035cb: 8211308: Support HTTP/2 in WebView
  • 6892fa1: 8232064: Switch FX build to use JDK 13.0.1 as boot JDK
  • 1d670f1: 8200224: Multiple press event when JFXPanel gains focus
  • 83eb0a7: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation
  • 798afbc: 8230610: Upgrade GStreamer to version 1.16.1

Your commit was automatically rebased without conflicts.

Pushed as commit 8367e1a.

@swpalmer swpalmer deleted the swpalmer:master branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.