8246202: ChoiceBoxSkin: misbehavior on switching skin, part 2

[kleopatra]

issue is a listener in ChoiceBoxSkin that wasn't removed (forgotten in my first cleanup ;)

Removed, un-ignored test that failed/passed before/after the fix

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8246202: ChoiceBoxSkin: misbehavior on switching skin, part 2

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ajit Ghaisas (@aghaisas - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/320/head:pull/320
$ git checkout pull/320

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (06c194d)
• 00: Full (72f6e1a)

[aghaisas]

along with @ignore, we need to get rid of this FIXME comment as well :)

[kleopatra]

darn oversight .. thanks for spotting it :)

[kevinrushforth]

Looks good.

[openjdk]

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8246202: ChoiceBoxSkin: misbehavior on switching skin, part 2

Reviewed-by: kcr, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• eb626aa: 8254040: [testbug] Need additional regressions tests for ObservableList removeAll / retainAll

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

@kleopatra Since your change was applied there has been 1 commit pushed to the master branch:

• eb626aa: 8254040: [testbug] Need additional regressions tests for ObservableList removeAll / retainAll

Your commit was automatically rebased without conflicts.

Pushed as commit e856a58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.