Skip to content

Conversation

@nlisker
Copy link
Collaborator

@nlisker nlisker commented Oct 18, 2020

Added 2 @defaultValue and fixed the incorrect default for editable. Also corrected a typo that doesn't show anyway in the docs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/323/head:pull/323
$ git checkout pull/323

@nlisker nlisker marked this pull request as ready for review October 18, 2020 11:31
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2020

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2020

⚠️ @nlisker a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 31fce21fb7e42b376e6dd159d422e691bd6cf1ae
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Ready for review label Oct 18, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2020

Webrevs

@kevinrushforth kevinrushforth self-requested a review October 20, 2020 21:34
@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@nlisker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254964: Fix default values in Spinner class

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Oct 20, 2020
@nlisker
Copy link
Collaborator Author

nlisker commented Oct 20, 2020

/integrate

@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Oct 20, 2020
@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@nlisker Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit a369938.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants