Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252596: [TESTBUG] WebPageShim::paint is not thread-safe #327

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Oct 21, 2020

Issue: Tests using WebPageShim::paint fails around 1/10 times.

Fix: Execute WebPageShim::paint in the render thread using PrismInvoker. Ran tests over 100 times, no failures.

Used the initial unit test in the PR for JDK-8202990.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252596: [TESTBUG] WebPageShim::paint is not thread-safe

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/327/head:pull/327
$ git checkout pull/327

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 21, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 21, 2020

Webrevs

@kevinrushforth kevinrushforth self-requested a review Oct 22, 2020
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I can confirm that it fixes the problem for me. On my machine the original test from JDK-8202990 fails quite often without this fix. I was able to run 100 iterations of the test with no failure with your fix.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@arun-Joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252596: [TESTBUG] WebPageShim::paint is not thread-safe

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 22, 2020
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Oct 22, 2020

/integrate

@openjdk openjdk bot closed this Oct 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 22, 2020
@arun-Joseph arun-Joseph deleted the arun-Joseph:8252596 branch Oct 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2020

@arun-Joseph Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 4e5f0e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants