Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256983: GitHub actions: specify the version of each platform OS and compiler #366

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 8, 2020

As described in the JBS issue, we should specify the specific version of each OS and compiler rather than just using the defaults. This will help insulate us from changes to the defaults that can break the build, and has recently done so.

On Linux, we upgraded to 20.04 (18.04 is still the default), which required specifying the version of ant, since the default version for 20.04 is 1.10.7 which has a bug that causes FX apps to fail. I decided to also specify the version of ant (1.10.5) for all three platforms.

The following will be used:

Platform OS Compiler Ant
Linux Ubuntu 20.04 gcc 10.2 ant 1.10.5
Mac macOS 10.15 Xcode 11.3.1 ant 1.10.5
Windows Windows Server 2019 [1] ant 1.10.5

[1] The Microsoft compiler version is unspecified as there is a dependency on JDK-8255713 in addition to the problem of increasing the build time to download a specific version.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256983: GitHub actions: specify the version of each platform OS and compiler

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/366/head:pull/366
$ git checkout pull/366

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 8, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 8, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 8, 2020

Webrevs

@kevinrushforth kevinrushforth requested a review from arapte Dec 10, 2020
@arapte
arapte approved these changes Dec 14, 2020
Copy link
Member

@arapte arapte left a comment

looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256983: GitHub actions: specify the version of each platform OS and compiler

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 97d655f: 8256012: Fix build of Monocle for Linux
  • e1adfa9: 8257758: Allow building of JavaFX native libs for Apple Silicon
  • 1a8652a: 8257719: JFXPanel scene fails to render correctly on HiDPI after fix for JDK-8199592
  • 7fa02fe: 8257897: Fix webkit build for XCode 12

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 14, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Dec 14, 2020

/integrate

@openjdk openjdk bot closed this Dec 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@kevinrushforth Since your change was applied there have been 5 commits pushed to the master branch:

  • ebb59e9: 8201568: zForce touchscreen input device fails when closed and immediately reopened
  • 97d655f: 8256012: Fix build of Monocle for Linux
  • e1adfa9: 8257758: Allow building of JavaFX native libs for Apple Silicon
  • 1a8652a: 8257719: JFXPanel scene fails to render correctly on HiDPI after fix for JDK-8199592
  • 7fa02fe: 8257897: Fix webkit build for XCode 12

Your commit was automatically rebased without conflicts.

Pushed as commit f2928d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8256983-gh-actions-platform branch Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants