Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259639: GitHub actions: build fails on Linux due to missing apt-get update #375

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 12, 2021

Simple fix to the submit.yml script to run apt-get update prior to installing needed packages on Linux. Without this, the request to install packages can fail to find the requested pacakges due to an out-of-date cache.

Compare the failing build before the fix with the successful build after the fix.

Note that this is targeted to jfx16 so that any subsequent pull request for jfx16 will be able to have a successful build on Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259639: GitHub actions: build fails on Linux due to missing apt-get update

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/375/head:pull/375
$ git checkout pull/375

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 12, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx16 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 12, 2021

Webrevs

arapte
arapte approved these changes Jan 12, 2021
Copy link
Member

@arapte arapte left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259639: GitHub actions: build fails on Linux due to missing apt-get update

Reviewed-by: arapte, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx16 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx16 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 12, 2021
Copy link
Collaborator

@pankaj-bansal pankaj-bansal left a comment

+1

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jan 12, 2021

/integrate

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@kevinrushforth Pushed as commit 9dd2058.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8259639-gh-actions-linux branch Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants