Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259864: Cleanup unused Prism files #378

Closed
wants to merge 2 commits into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Jan 16, 2021

Fix for JDK-8259864
Remove java and native files that are not used/maintained in prism configurations.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/378/head:pull/378
$ git checkout pull/378

Fix for JDK-8259864
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 16, 2021

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 16, 2021

Webrevs

@kevinrushforth kevinrushforth self-requested a review Jan 16, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 16, 2021

There are references to eglx11 and eglfb in some of the buildSrc/*.gradle files. I recommend cleaning those up, too.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 16, 2021

I also see references in ES2Pipeline.java, GLFactory.java and PrismES2Defs.h. Should those be removed, too?

Remove more references to egl{fb/x11}
@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Jan 18, 2021

I removed more references.
Note that not all references are removed, since e.g. the flag EGL_FB might also be passed to the c compiler when compiling for non-eglfb systems. This requires another cleanup.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2021

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259864: Cleanup unused Prism files

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 20, 2021
@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Jan 20, 2021

/integrate

@openjdk openjdk bot closed this Jan 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2021

@johanvos Pushed as commit 9d06bd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants