8252389: Fix mistakes in FX API docs

[nlisker]

The usual doc fixes (for OpenJFX 16).

Can wait until RDP2 to see if something else comes up.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252389: Fix mistakes in FX API docs

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/380/head:pull/380
$ git checkout pull/380

[bridgekeeper]

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into jfx16 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[nlisker]

/reviewers 2

[openjdk]

@nlisker
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[mlbridge]

Webrevs

• 02: Full - Incremental (5ba0799)
• 01: Full - Incremental (ba164e5)
• 00: Full (148ce0f)

[kleopatra]

wondering how small a doc error is small enough to go into this: just noticed that Skinnable talks about "Control" in all of its methods - should be "Skinnable" everywhere (except as example implementation in overview doc), IMO. But then, the overview doc is .. lame as well, so might need its own bug anyway?

[nlisker]

I don't mind making the "Control" -> "Skinnable" changes if you detail them, but rewriting the class doc should be it's own issue, in which case you can fix these mistakes there as well.

[kleopatra]

thanks, that's about the lines of my thoughts as well :) Will file a separate doc bug for skinnable cleanup

[kleopatra]

thanks, that's about the lines of my thoughts as well :) Will file a separate doc bug for skinnable cleanup

fyi: just filed https://bugs.openjdk.java.net/browse/JDK-8260364

[kevinrushforth]

@nlisker I'll wait to review this until after you add the fix noted in JDK-8260430.

[nlisker]

I added a fix for JDK-8260430. Note that the underlying behavior in this class is different than that of Node. While both have a map of properties, Node uses a special key to add/get the user data to/from the map while MenuItem has a separate field for it. In Node these methods are convenience methods, but here they have a separate functionality.

[kevinrushforth]

I left two additional comments. Otherwise good.

[openjdk]

@nlisker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252389: Fix mistakes in FX API docs

Reviewed-by: aghaisas, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx16 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx16 branch, type /integrate in a new comment.

[nlisker]

/integrate

[openjdk]

@nlisker Pushed as commit 0f20a98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.