New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259635: Update to 610.2 version of WebKit #382
Conversation
|
Webrevs
|
/reviewers 3 |
@kevinrushforth |
I reviewed all of the changes outside
These are not equivalent colors. Is this intentional? |
It should be |
Build and tests pass on windows/linux/mac in our CI. |
Looks good. Build + automated tests passed on all three platforms. I ran into one manual test issue related to input events on Linux only. I'll file a follow-on bug for that.
I filed JDK-8260257 to track the Linux input event issue. |
Changes looks good to me. Did a local build on all three Platform and sanity test by loading top 10 websites loaded without any deviation from old build.
@arun-Joseph This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@arun-Joseph Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b0a404d. |
Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/382/head:pull/382
$ git checkout pull/382