Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260246: Ensemble: Update version of Lucene to 7.7.3 #387

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 27, 2021

This updates to the latest bug fix version of Lucene 7, which is version 7.7.3. Since it is only an update to the micro version, there is no need to regenerate the index. See UPDATING-lucene.txt.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260246: Ensemble: Update version of Lucene to 7.7.3

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/387/head:pull/387
$ git checkout pull/387

@kevinrushforth kevinrushforth requested a review from aghaisas Jan 27, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 27, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 27, 2021

Webrevs

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Feb 3, 2021

I applied the patch and tested on macOS 10.15.7.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260246: Ensemble: Update version of Lucene to 7.7.3

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • e481f8c: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows
  • 217a8cb: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys
  • db6941d: 8256283: IndexOutOfBoundsException when sorting a TreeTableView
  • b0a404d: 8259635: Update to 610.2 version of WebKit
  • 6c1a0ca: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 3, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Feb 3, 2021

/integrate

@openjdk openjdk bot closed this Feb 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@kevinrushforth Since your change was applied there have been 5 commits pushed to the master branch:

  • e481f8c: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows
  • 217a8cb: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys
  • db6941d: 8256283: IndexOutOfBoundsException when sorting a TreeTableView
  • b0a404d: 8259635: Update to 610.2 version of WebKit
  • 6c1a0ca: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

Your commit was automatically rebased without conflicts.

Pushed as commit 215384d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8260246-lucene-7.7.3 branch Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants