Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234194: [TEST_BUG] Reenable few graphics unit tests #39

Closed

Conversation

@arapte
Copy link

arapte commented Nov 14, 2019

Following graphics unit tests can be re-enabled.

  1. test.com.sun.javafx.scene.layout.region.BackgroundRepeatConverterTest.scenario2
    RepeatStructConverter.convert() is an internal method and does not verify the parameters. Passing null value to this method results in NPE.

  2. test.javafx.scene.layout.RegionCSSTest.borderImageWidth_auto
    test.javafx.scene.layout.RegionCSSTest.borderImageWidth_1_auto
    test.javafx.scene.layout.RegionCSSTest.borderImageWidth_1_2Percent_auto
    It is not certain if the value of auto for -fx-border-image-width is 1 or 2 by defaut. But the tests seem correct and they pass.

  3. test.javafx.scene.Node_cssMethods_Test
    JDK-8094155 is fixed and the tests can be re-enabled.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8234194: [TEST_BUG] Reenable few graphics unit tests

Approvers

  • Kevin Rushforth (kcr - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2019

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 14, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2019

Webrevs

Copy link
Member

kevinrushforth left a comment

Most of this looks OK, but there is one I had a question on.

Have you run this on all platforms?

@arapte
Copy link
Author

arapte commented Nov 15, 2019

Have you run this on all platforms?

Yes, The change is verified on platforms. and It shows same result.
tests: 22988, fails: 0, ignored: 279

Also I have included few more tests to enable, please take a look.

Copy link
Member

kevinrushforth left a comment

Looks good.

@openjdk openjdk bot removed the rfr label Nov 15, 2019
@openjdk
Copy link

openjdk bot commented Nov 15, 2019

@arapte This change can now be integrated. The commit message will be:

8234194: [TEST_BUG] Reenable few graphics unit tests

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 15, 2019
@arapte
Copy link
Author

arapte commented Nov 16, 2019

/integrate

@openjdk openjdk bot closed this Nov 16, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 16, 2019
@openjdk
Copy link

openjdk bot commented Nov 16, 2019

@arapte The following commits have been pushed to master since your change was applied:

  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

Your commit was automatically rebased without conflicts.

Pushed as commit 4f496d4.

@mlbridge
Copy link

mlbridge bot commented Nov 16, 2019

Mailing list message from Ambarish Rapte on openjfx-dev:

Changeset: 4f496d4
Author: Ambarish Rapte
Date: 2019-11-16 16:07:10 +0000
URL: https://git.openjdk.java.net/jfx/commit/4f496d41

8234194: [TEST_BUG] Reenable few graphics unit tests

Reviewed-by: kcr

! modules/javafx.graphics/src/test/java/test/com/sun/javafx/scene/layout/region/BackgroundRepeatConverterTest.java
! modules/javafx.graphics/src/test/java/test/com/sun/scenario/animation/shared/TimelineClipCoreTest.java
! modules/javafx.graphics/src/test/java/test/javafx/css/Node_cssStyleMap_Test.java
! modules/javafx.graphics/src/test/java/test/javafx/scene/Node_cssMethods_Test.java
! modules/javafx.graphics/src/test/java/test/javafx/scene/layout/RegionCSSTest.java

@arapte arapte deleted the arapte:Re-enable_ignored_graphics_unit_tests branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.