Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234194: [TEST_BUG] Reenable few graphics unit tests #39

Closed
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -26,14 +26,13 @@
package test.com.sun.javafx.scene.layout.region;

import javafx.scene.layout.BackgroundRepeat;
import org.junit.Ignore;
import org.junit.Test;
import javafx.css.ParsedValue;
import com.sun.javafx.css.ParsedValueImpl;
import com.sun.javafx.scene.layout.region.RepeatStruct;

import static org.junit.Assert.assertEquals;
import com.sun.javafx.scene.layout.region.RepeatStructConverter;
import static org.junit.Assert.fail;
import com.sun.javafx.scene.layout.region.RepeatStructConverter;

/**
@@ -54,8 +53,8 @@
/*
-fx-background-repeat: null
*/
@Ignore ("this doesn't work, but I'm not sure what would happen with a null background-repeat in reality")
@Test public void scenario2() {
@Test
public void scenario2() {
ParsedValue<String,BackgroundRepeat>[][] values = new ParsedValueImpl[][] {
{null}
};
@@ -64,8 +63,12 @@
new ParsedValueImpl<ParsedValue<String,BackgroundRepeat>[][], RepeatStruct[]>(
values, null
);
RepeatStruct[] results = RepeatStructConverter.getInstance().convert(value, null);
assertEquals(0, results.length, 0);
try {
RepeatStruct[] results = RepeatStructConverter.getInstance().convert(value, null);
fail("Expected NullPointerException");
} catch (NullPointerException expected) {
// Test Pass, NPE is expected
}
}

/*
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -39,7 +39,6 @@
import javafx.util.Duration;

import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;

import java.io.IOException;
@@ -181,7 +180,6 @@ public void write(int i) throws IOException {
assertEquals(3, eventHandler.callCount);
}

@Ignore
@Test
public void testJumpTo() {
// jumpTo on stopped timeline
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -65,7 +65,6 @@
import org.junit.Ignore;
import org.junit.Test;

@Ignore
public class Node_cssStyleMap_Test {

public Node_cssStyleMap_Test() {
@@ -101,6 +100,7 @@ private void checkFoundStyle(Property<?> property, Map<StyleableProperty<?>, Lis

}

@Ignore("JDK-8234241")
This conversation was marked as resolved by arapte

This comment has been minimized.

Copy link
@kevinrushforth

kevinrushforth Nov 15, 2019

Member

Based on the description in JBS, I presume that JDK-8234241 is a test bug? If so, can you label the new bug as such?

This comment has been minimized.

Copy link
@arapte

arapte Nov 16, 2019

Author

Hi Kevin, I have updated the JBS.

@Test
public void testStyleMap() {

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2016, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -34,7 +34,6 @@
import javafx.scene.shape.Rectangle;

import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
@@ -49,7 +48,6 @@
import javafx.scene.ImageCursor;
import javafx.scene.Node;

@Ignore ("pending RT-35594")
@RunWith(Parameterized.class)
public final class Node_cssMethods_Test extends CssMethodsTestBase {
private static final Node TEST_NODE = new Rectangle();
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -3375,7 +3375,6 @@ private static String dump(BackgroundPosition position) {
assertEquals(expected, image);
}

@Ignore("I am not certain that supporting auto makes sense for us, and if it does, is it anything other than 1?")
@Test public void borderImageWidth_auto() {
region.setStyle(
"-fx-border-image-source: url('test/javafx/scene/layout/center-btn.png');" +
@@ -3397,7 +3396,6 @@ private static String dump(BackgroundPosition position) {
assertEquals(expected, image);
}

@Ignore("I am not certain that supporting auto makes sense for us, and if it does, is it anything other than 1?")
@Test public void borderImageWidth_1_auto() {
region.setStyle(
"-fx-border-image-source: url('test/javafx/scene/layout/center-btn.png');" +
@@ -3418,7 +3416,6 @@ private static String dump(BackgroundPosition position) {
assertEquals(expected, image);
}

@Ignore("I am not certain that supporting auto makes sense for us, and if it does, is it anything other than 1?")
@Test public void borderImageWidth_1_2Percent_auto() {
region.setStyle(
"-fx-border-image-source: url('test/javafx/scene/layout/center-btn.png');" +
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.