Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234194: [TEST_BUG] Reenable few graphics unit tests #39

Closed
Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -32,7 +32,7 @@
import com.sun.javafx.scene.layout.region.RepeatStruct;

import static org.junit.Assert.assertEquals;
import com.sun.javafx.scene.layout.region.RepeatStructConverter;
import static org.junit.Assert.fail;
import com.sun.javafx.scene.layout.region.RepeatStructConverter;

/**
@@ -53,7 +53,7 @@
/*
-fx-background-repeat: null
*/
@Test(expected=NullPointerException.class)
@Test
public void scenario2() {
ParsedValue<String,BackgroundRepeat>[][] values = new ParsedValueImpl[][] {
{null}
@@ -63,7 +63,12 @@ public void scenario2() {
new ParsedValueImpl<ParsedValue<String,BackgroundRepeat>[][], RepeatStruct[]>(
values, null
);
RepeatStruct[] results = RepeatStructConverter.getInstance().convert(value, null);
try {
RepeatStruct[] results = RepeatStructConverter.getInstance().convert(value, null);
fail("Expected NullPointerException");
} catch (NullPointerException expected) {
// Test Pass, NPE is expected
}
}

/*
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -39,7 +39,6 @@
import javafx.util.Duration;

import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;

import java.io.IOException;
@@ -181,7 +180,6 @@ public void write(int i) throws IOException {
assertEquals(3, eventHandler.callCount);
}

@Ignore
@Test
public void testJumpTo() {
// jumpTo on stopped timeline
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -65,7 +65,6 @@
import org.junit.Ignore;
import org.junit.Test;

@Ignore
public class Node_cssStyleMap_Test {

public Node_cssStyleMap_Test() {
@@ -101,6 +100,7 @@ private void checkFoundStyle(Property<?> property, Map<StyleableProperty<?>, Lis

}

@Ignore("JDK-8234241")
This conversation was marked as resolved by arapte

This comment has been minimized.

@kevinrushforth

kevinrushforth Nov 15, 2019 Member

Based on the description in JBS, I presume that JDK-8234241 is a test bug? If so, can you label the new bug as such?

This comment has been minimized.

@arapte

arapte Nov 16, 2019 Author Member

Hi Kevin, I have updated the JBS.

@Test
public void testStyleMap() {

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.