8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows

[arun-joseph]

Windows uses WorkQueueGeneric instead of WorkQueueWin from WebKit 610.2 onwards. In WorkQueueWin, WorkQueue::dispatchAfter() had a 20 ms slopAdjustment as the timer (called from ::SetTimer) sometimes fire a few ms early. The same is not present in WorkQueueGeneric and needs to be added.

Also removing WorkQueueWin as it's removed for WebKit as well.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/391/head:pull/391
$ git checkout pull/391

[bridgekeeper]

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (ea61414)
• 00: Full (739f320)

[kevinrushforth]

The fix and the test look good with one question and one doc comment.

[kevinrushforth]

Looks good.

[openjdk]

@arun-joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 217a8cb: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys
• db6941d: 8256283: IndexOutOfBoundsException when sorting a TreeTableView

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[arun-joseph]

/integrate

[openjdk]

@arun-joseph Since your change was applied there have been 2 commits pushed to the master branch:

• 217a8cb: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys
• db6941d: 8256283: IndexOutOfBoundsException when sorting a TreeTableView

Your commit was automatically rebased without conflicts.

Pushed as commit e481f8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.