Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254836: Cherry pick GTK WebKit 2.30.3 changes #392

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Feb 3, 2021

Update to GTK WebKit 2.30.3
https://webkitgtk.org/2020/11/20/webkitgtk2.30.3-released.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/392/head:pull/392
$ git checkout pull/392

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 3, 2021

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 3, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 3, 2021

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 3, 2021

@johanvos @tiainen can you test this in your environment?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Feb 4, 2021

We're creating test-builds in our CI for this now.

Copy link
Collaborator

@johanvos johanvos left a comment

sanity checks pass

@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@arun-Joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254836: Cherry pick GTK WebKit 2.30.3 changes

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 215384d: 8260246: Ensemble: Update version of Lucene to 7.7.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 4, 2021
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Feb 4, 2021

/integrate

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@arun-Joseph Since your change was applied there has been 1 commit pushed to the master branch:

  • 215384d: 8260246: Ensemble: Update version of Lucene to 7.7.3

Your commit was automatically rebased without conflicts.

Pushed as commit 425c335.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arun-Joseph arun-Joseph deleted the 8254836 branch Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants