Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252099: JavaFX does not render Myanmar script correctly #399

Closed
wants to merge 1 commit into from

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Feb 9, 2021

This PR allows rendering Myanmar script correctly, following up on https://bugs.openjdk.java.net/browse/JDK-8223558.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252099: JavaFX does not render Myanmar script correctly

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/399/head:pull/399
$ git checkout pull/399

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2021

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 9, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2021

Webrevs

@kevinrushforth
Copy link
Member

It looks fine to me. Not sure whether there is a good way to have an automated test, but as the fix is simple enough, we can take it as long as you've verified it manually.

@prrace any comments on this fix?

@openjdk
Copy link

openjdk bot commented Feb 10, 2021

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252099: JavaFX does not render Myanmar script correctly

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 10, 2021
@magwas
Copy link

magwas commented Feb 10, 2021

Hi @magwas, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user magwas for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

@jperedadnr
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Feb 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Feb 10, 2021
@openjdk
Copy link

openjdk bot commented Feb 10, 2021

@jperedadnr Pushed as commit a23d4ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants