New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252099: JavaFX does not render Myanmar script correctly #399
Conversation
👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into |
It looks fine to me. Not sure whether there is a good way to have an automated test, but as the fix is simple enough, we can take it as long as you've verified it manually. @prrace any comments on this fix? |
@jperedadnr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Hi @magwas, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user magwas for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.
Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use. |
/integrate |
@jperedadnr Pushed as commit a23d4ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR allows rendering Myanmar script correctly, following up on https://bugs.openjdk.java.net/browse/JDK-8223558.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/399/head:pull/399
$ git checkout pull/399