Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233421: Upgrade to Visual Studio 2017 version 15.9.16 #40

Closed

Conversation

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 14, 2019

JDK-8233421

This bumps the windows compiler version to VS2017 version 15.9.16 to match JDK 14. I have run a full build and test, including WebKit and media.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8233421: Upgrade to Visual Studio 2017 version 15.9.16

Approvers

  • Phil Race (prr - Reviewer)
  • Ambarish Rapte (arapte - Reviewer)
  • Johan Vos (jvos - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2019

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 14, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2019

Webrevs

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Nov 14, 2019

Reviewers: @arapte @johanvos

@prrace
prrace approved these changes Nov 14, 2019
@openjdk openjdk bot removed the rfr label Nov 14, 2019
@openjdk
Copy link

openjdk bot commented Nov 14, 2019

@kevinrushforth This change can now be integrated. The commit message will be:

8233421: Upgrade to Visual Studio 2017 version 15.9.16

Reviewed-by: prr, arapte, jvos
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests
  • e37cb37: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest
  • 4f496d4: 8234194: [TEST_BUG] Reenable few graphics unit tests
  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 14, 2019
@kevinrushforth kevinrushforth requested a review from johanvos Nov 18, 2019
@kevinrushforth kevinrushforth self-assigned this Nov 18, 2019
@arapte
arapte approved these changes Nov 18, 2019
Copy link
Member

arapte left a comment

lgtm, verified that build artifacts are same before and after change on Windows 10, Visual Studio 2017.

Copy link
Collaborator

johanvos left a comment

build and sanity check pass on windows (and, fwiw, other platforms)

@kevinrushforth kevinrushforth mentioned this pull request Nov 18, 2019
3 of 3 tasks complete
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Nov 18, 2019

/integrate

@openjdk openjdk bot closed this Nov 18, 2019
@openjdk openjdk bot added the integrated label Nov 18, 2019
@openjdk
Copy link

openjdk bot commented Nov 18, 2019

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests
  • e37cb37: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest
  • 4f496d4: 8234194: [TEST_BUG] Reenable few graphics unit tests
  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

Your commit was automatically rebased without conflicts.

Pushed as commit 95ad601.

@openjdk openjdk bot removed the ready label Nov 18, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2019

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: 95ad601
Author: Kevin Rushforth
Date: 2019-11-18 18:17:14 +0000
URL: https://git.openjdk.java.net/jfx/commit/95ad6017

8233421: Upgrade to Visual Studio 2017 version 15.9.16

Reviewed-by: prr, arapte, jvos

! build.properties

@kevinrushforth kevinrushforth deleted the kevinrushforth:8233421-vs2017-15.9.16 branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.