Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261460: Incorrect CSS applied to ContextMenu on DialogPane #400

Closed
wants to merge 4 commits into from

Conversation

@abhinayagarwal
Copy link
Contributor

@abhinayagarwal abhinayagarwal commented Feb 10, 2021

Both DialogPane and ContextMenu have a child node with a style-class graphic-container. This leads to a corner case where an unwanted style is applied to ContextMenu when it is shown on a DialogPane.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261460: Incorrect CSS applied to ContextMenu on DialogPane

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/400/head:pull/400
$ git checkout pull/400

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 10, 2021

👋 Welcome back abhinayagarwal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 13, 2021

This looks like a simple and safe fix, but I'd like a second reviewer for anything that touches the modena.css stylesheet.

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Feb 13, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Both the fix and the new tests look good to me. I can confirm that it fixes the test program attached to JBS, and that the new ContextMenu unit test fails before and passes after the fix.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@abhinayagarwal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261460: Incorrect CSS applied to ContextMenu on DialogPane

Reviewed-by: kcr, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms
  • a23d4ae: 8252099: JavaFX does not render Myanmar script correctly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 18, 2021
@abhinayagarwal
Copy link
Contributor Author

@abhinayagarwal abhinayagarwal commented Feb 19, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@abhinayagarwal
Your change (at version ad6337f) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 19, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@kevinrushforth @abhinayagarwal Since your change was applied there have been 2 commits pushed to the master branch:

  • 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms
  • a23d4ae: 8252099: JavaFX does not render Myanmar script correctly

Your commit was automatically rebased without conflicts.

Pushed as commit f02019f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants