Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261927: WebKit build fails with Visual Studio 2017 #405

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Feb 18, 2021

The WebKit build fails with Visual Studio 2017.

Issue: Visual Studio 2017 doesn't support if constexpr in lambda

Test: Build webkit with the VS2017 compiler with and without this fix. It should fail without the fix and build with the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261927: WebKit build fails with Visual Studio 2017

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/405/head:pull/405
$ git checkout pull/405

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2021

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2021

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 18, 2021

This is restoring a change that went into WebKit 610.1 but was lost during the upgrade to 610.2. It is a straightforward change, but would be good to get a second reviewer.

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Validated with both VS 2017 and VS 2019.

guruhb
guruhb approved these changes Feb 21, 2021
Copy link
Collaborator

@guruhb guruhb left a comment

Compiled and verified on VS 2017. Changes looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2021

@arun-Joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261927: WebKit build fails with Visual Studio 2017

Reviewed-by: kcr, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 4733824: 8252935: Add treeShowing listener only when needed
  • f02019f: 8261460: Incorrect CSS applied to ContextMenu on DialogPane
  • 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 21, 2021
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Feb 21, 2021

/integrate

@openjdk openjdk bot closed this Feb 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2021

@arun-Joseph Since your change was applied there have been 3 commits pushed to the master branch:

  • 4733824: 8252935: Add treeShowing listener only when needed
  • f02019f: 8261460: Incorrect CSS applied to ContextMenu on DialogPane
  • 782f22a: 8248126: JavaFX ignores HiDPI scaling settings on some linux platforms

Your commit was automatically rebased without conflicts.

Pushed as commit 9e42eea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arun-Joseph arun-Joseph deleted the 8261927 branch Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants