Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260165: CSSFilterTest.testCSSFilterRendering system test fails #408

Closed
wants to merge 2 commits into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Feb 22, 2021

Issue: Initial layout delay was removed and layout() is called from layoutTimer instead of WebPage::prePaint().

Fix: Re-introduce the initial layout delay.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260165: CSSFilterTest.testCSSFilterRendering system test fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/408/head:pull/408
$ git checkout pull/408

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 22, 2021

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@arun-Joseph arun-Joseph marked this pull request as ready for review Feb 24, 2021
@openjdk openjdk bot added the rfr label Feb 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 24, 2021

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 24, 2021

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review Feb 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 24, 2021

This seems a safe enough fix to restore the layout delay that was removed in WebKit 610.2 (and which has caused a regression). Are there any drawbacks to doing this?

@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Feb 24, 2021

The only drawback would be layout is calculated in the next updateContent cycle instead of right after loading the first page, which is same as before WebKit 610.2. This would only cause a delay of a few milliseconds (~10 ms for this test).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Tested on all three platforms.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 24, 2021

@johanvos @guruhb can one of you be the second reviewer on this?

@kevinrushforth kevinrushforth requested a review from guruhb Feb 26, 2021
@guruhb
guruhb approved these changes Feb 26, 2021
Copy link
Collaborator

@guruhb guruhb left a comment

Tested on Linux and Windows, Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 26, 2021

@arun-Joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260165: CSSFilterTest.testCSSFilterRendering system test fails

Reviewed-by: kcr, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • dc91f64: 8260257: [Linux] WebView no longer reacts to some mouse events
  • dc342d3: 8262236: Configure Gradle checksum verification
  • e25d39b: 8260468: Wrong behavior of LocalDateTimeStringConverter
  • 9e42eea: 8261927: WebKit build fails with Visual Studio 2017
  • 4733824: 8252935: Add treeShowing listener only when needed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 26, 2021
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Feb 26, 2021

/integrate

@openjdk openjdk bot closed this Feb 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 26, 2021

@arun-Joseph Since your change was applied there have been 5 commits pushed to the master branch:

  • dc91f64: 8260257: [Linux] WebView no longer reacts to some mouse events
  • dc342d3: 8262236: Configure Gradle checksum verification
  • e25d39b: 8260468: Wrong behavior of LocalDateTimeStringConverter
  • 9e42eea: 8261927: WebKit build fails with Visual Studio 2017
  • 4733824: 8252935: Add treeShowing listener only when needed

Your commit was automatically rebased without conflicts.

Pushed as commit 8ad18c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arun-Joseph arun-Joseph deleted the arun-Joseph:8260165 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants