Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233420: Upgrade to gcc 8.3 on Linux #41

Closed
wants to merge 2 commits into from

Conversation

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 14, 2019

JDK-8233420

This bumps the Linux compiler version to gcc 8.3 to match JDK 14. I have run a full build and test, including WebKit and media.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8233420: Upgrade to gcc 8.3 on Linux

Approvers

  • Ambarish Rapte (arapte - Reviewer) Note! Review applies to ab06dc5
  • Johan Vos (jvos - Reviewer) Note! Review applies to ab06dc5
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2019

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Nov 14, 2019

Reviewers: @arapte @johanvos

@openjdk openjdk bot added the rfr label Nov 14, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2019

Webrevs

@kevinrushforth kevinrushforth self-assigned this Nov 18, 2019
@kevinrushforth kevinrushforth requested a review from johanvos Nov 18, 2019
@arapte
arapte approved these changes Nov 18, 2019
Copy link

arapte left a comment

lgtm, verified build artifacts on Ubuntu18.04 LTS.

@openjdk openjdk bot removed the rfr label Nov 18, 2019
@openjdk
Copy link

openjdk bot commented Nov 18, 2019

@kevinrushforth This change can now be integrated. The commit message will be:

8233420: Upgrade to gcc 8.3 on Linux

Reviewed-by: arapte, jvos
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 18, 2019
Copy link
Collaborator

johanvos left a comment

build and sanity checks pass on linux (and fwiw, on mac/win too)

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Nov 18, 2019

After integrating PR #40 (VS2017 15.9.16 upgrade) I will need to merge in the changes from master to resolve a trivial merge conflict, because the modified lines for the two PRs are adjacent to one another. There will be no change in the diffs other than the surrounding context.

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Nov 18, 2019

/integrate

@openjdk openjdk bot closed this Nov 18, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 18, 2019
@openjdk
Copy link

openjdk bot commented Nov 18, 2019

@kevinrushforth
Pushed as commit aad1720.

@mlbridge
Copy link

mlbridge bot commented Nov 18, 2019

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: aad1720
Author: Kevin Rushforth
Date: 2019-11-18 18:40:00 +0000
URL: https://git.openjdk.java.net/jfx/commit/aad17206

8233420: Upgrade to gcc 8.3 on Linux

Reviewed-by: arapte, jvos

! build.properties

@kevinrushforth kevinrushforth deleted the kevinrushforth:8233420-gcc-8.3 branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.