New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263204: Add Gradle Wrapper Validation Action #419
Conversation
|
This sounds like a good plan to test it. |
Webrevs
|
It might be better to include the validation task in the same If there is a good reason to keep it in a separate file, then I would at least duplicate this part from submit.yml:
|
Thanks, Kevin. I'll merge the two workflow files. The test results aren't what I expected: I assumed the wrapper validation would fail and prevent the builds from running. Should I try to make the three build steps dependent on the success of the wrapper validation? There might be a way to make the steps sequential and conditional. |
If it isn't too hard to make the running of the other three jobs dependent on the wrapper validation job, that would be good, as long as the validation job is fast. The other three still need to run in parallel with each other. Alternatively, you could make the wrapper validation a task that is replicated in each of the three jobs. |
Consolidate the two GitHub workflow files and make the three build jobs dependent on the success of the Gradle Wrapper validation.
Okay, this is looking better! The validation took only 23 seconds, and GitHub shows the following results: The screenshot below shows the notification I received by e-mail: Now we'll see whether the three build jobs still run in parallel when the wrapper validation succeeds. My next commit will restore the Gradle Wrapper JAR file. |
Yep, they are running in parallel. And this provides a nice view: |
@jgneff This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.
|
/integrate |
/sponsor |
@kevinrushforth @jgneff Pushed as commit 75b4c15. |
See the Gradle Wrapper Validation Action for details on this pull request. I'll test the changes with the following sequence of commits:
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/419/head:pull/419
$ git checkout pull/419