Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234239: [TEST_BUG] Reenable few ignored web tests #42

Closed
wants to merge 3 commits into from

Conversation

@arun-Joseph
Copy link
Contributor

arun-Joseph commented Nov 15, 2019

The following tests can be reenabled:

CookieManager.testPutOverwriteExpired
CookieManager.testPutPurgeDomainAfterExpiry
CookieManager.testPutPurgeCookiesGlobally2
CookieManager.testPutPurgeCookiesGlobally3
CookieManager.testPutPurgeCookiesGloballyAfterExpiry
CallbackTest.testCustomPopup
CallbackTest.testDefaultPopup
LeakTest.testGarbageCollectability
LeakTest.testOleg
MiscellaneousTest.testRT30835

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8234239: [TEST_BUG] Reenable few ignored web tests

Approvers

  • Kevin Rushforth (kcr - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2019

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 15, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2019

Webrevs

Copy link
Member

kevinrushforth left a comment

I added some questions and one requested change below.

Copy link
Member

kevinrushforth left a comment

Looks good.

@openjdk openjdk bot removed the rfr label Nov 18, 2019
@openjdk
Copy link

openjdk bot commented Nov 18, 2019

@arun-Joseph This change can now be integrated. The commit message will be:

8234239: [TEST_BUG] Reenable few ignored web tests

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests
  • e37cb37: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest
  • 4f496d4: 8234194: [TEST_BUG] Reenable few graphics unit tests
  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@openjdk openjdk bot added the ready label Nov 18, 2019
@arun-Joseph
Copy link
Contributor Author

arun-Joseph commented Nov 18, 2019

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2019

@arun-Joseph
Your change (at version 8c2b988) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Nov 18, 2019
@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 18, 2019

/sponsor

@openjdk openjdk bot closed this Nov 18, 2019
@openjdk openjdk bot added integrated and removed sponsor labels Nov 18, 2019
@openjdk
Copy link

openjdk bot commented Nov 18, 2019

@kevinrushforth @arun-Joseph The following commits have been pushed to master since your change was applied:

  • 95ad601: 8233421: Upgrade to Visual Studio 2017 version 15.9.16
  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests
  • e37cb37: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest
  • 4f496d4: 8234194: [TEST_BUG] Reenable few graphics unit tests
  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests

Your commit was automatically rebased without conflicts.

Pushed as commit aab07a4.

@openjdk openjdk bot removed the ready label Nov 18, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2019

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: aab07a4
Author: Arun Joseph
Committer: Kevin Rushforth
Date: 2019-11-18 18:17:39 +0000
URL: https://git.openjdk.java.net/jfx/commit/aab07a4d

8234239: [TEST_BUG] Reenable few ignored web tests

Reviewed-by: kcr

! modules/javafx.web/src/test/java/test/com/sun/webkit/network/CookieManagerTest.java
! modules/javafx.web/src/test/java/test/javafx/scene/web/CallbackTest.java
! modules/javafx.web/src/test/java/test/javafx/scene/web/LeakTest.java
! modules/javafx.web/src/test/java/test/javafx/scene/web/MiscellaneousTest.java

@arun-Joseph arun-Joseph deleted the arun-Joseph:8234239 branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.