Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234239: [TEST_BUG] Reenable few ignored web tests #42

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -37,7 +37,6 @@
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import org.junit.Ignore;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
@@ -407,10 +406,7 @@ public void testPutOverwrite() {

/**
* Tests if put() correctly overwrites expired cookie.
* This test is disabled because it takes considerable amount of time
* to run.
*/
@Ignore
@Test
public void testPutOverwriteExpired() {
put("http://example.org/", "foo=bar; Max-Age=1; HttpOnly");
@@ -497,10 +493,7 @@ public void testPutPurgeDomain3() {
/**
* Tests if put() correctly purges individual domains
* and takes into account cookie expiry.
* This test is disabled because it takes considerable amount of time
* to run.
*/
@Ignore
@Test
public void testPutPurgeDomainAfterExpiry() {
for (int i = 0; i < 25; i++) {
@@ -547,10 +540,7 @@ public void testPutPurgeCookiesGlobally1() {

/**
* Tests if put() correctly purges cookies globally.
* This test is disabled because it takes considerable amount of time
* to run.
*/
@Ignore
@Test
public void testPutPurgeCookiesGlobally2() {
String urip = "http://example%d.org/";
@@ -579,10 +569,7 @@ public void testPutPurgeCookiesGlobally2() {

/**
* Tests if put() correctly purges cookies globally.
* This test is disabled because it takes considerable amount of time
* to run.
*/
@Ignore
@Test
public void testPutPurgeCookiesGlobally3() {
String urip = "http://example%d.org/";
@@ -612,10 +599,7 @@ public void testPutPurgeCookiesGlobally3() {
/**
* Tests if put() correctly purges cookies globally and takes
* into account cookie expiry.
* This test is disabled because it takes considerable amount of time
* to run.
*/
@Ignore
@Test
public void testPutPurgeCookiesGloballyAfterExpiry() {
String urip = "http://example%d.org/";
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -42,7 +42,6 @@
import javafx.scene.web.WebEvent;
import javafx.util.Callback;

import org.junit.Ignore;
import org.junit.Test;


@@ -88,7 +87,6 @@ private void clear() {
popupUi.clear();
}

@Ignore("RT-34508")
@Test public void testDefaultPopup() {
This conversation was marked as resolved by arun-Joseph

This comment has been minimized.

Copy link
@kevinrushforth

kevinrushforth Nov 15, 2019

Member

This test, along with testCustomPopup is listed as unstable. Have you run it multiple times on different systems?

This comment has been minimized.

Copy link
@arun-Joseph

arun-Joseph Nov 17, 2019

Author Contributor

Yes, I've run the test multiple times in all 3 platforms and it's passing everytime.

This comment has been minimized.

Copy link
@kevinrushforth

kevinrushforth Nov 18, 2019

Member

OK. In that case, please close RT-34508, aka JDK-8090082, as "Cannot reproduce".

clear();
executeScript(JS_OPEN_DEFAULT);
@@ -106,7 +104,6 @@ private void checkDefaultPopup() {
popupUi.checkCalled(VISIBILITY_CHANGED, true);
}

@Ignore("RT-34508")
@Test public void testCustomPopup() {
clear();
executeScript(JS_OPEN);
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -45,7 +45,6 @@
import javafx.scene.web.WebView;
import javafx.util.Duration;
import netscape.javascript.JSObject;
import org.junit.Ignore;
import org.junit.Test;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
@@ -56,7 +55,6 @@

private static final int SLEEP_TIME = 1000;

@Ignore // RT-26710: javafx.scene.web.LeakTest hangs
@Test public void testOleg() throws InterruptedException{
This conversation was marked as resolved by kevinrushforth

This comment has been minimized.

Copy link
@kevinrushforth

kevinrushforth Nov 15, 2019

Member

This test takes 80 seconds (16 * 5 * 1sec) to run, which is too long for a simple unit test, when the entire rest of the test suite takes about 5 minutes. I recommend decreasing the duration of the key frame to 200 msec, which would allow the test to run in 16 seconds.

final String URL = new File("src/test/resources/test/html/guimark2-vector.html").toURI().toASCIIString();
final int CYCLE_COUNT = 16;
@@ -65,7 +63,7 @@

Timeline time = new Timeline();
time.setCycleCount(CYCLE_LENGTH * CYCLE_COUNT);
time.getKeyFrames().add(new KeyFrame(Duration.millis(1000), new EventHandler<ActionEvent>() {
time.getKeyFrames().add(new KeyFrame(Duration.millis(200), new EventHandler<ActionEvent>() {
int counter = -1;
@Override public void handle(final ActionEvent e) {
++counter;
@@ -82,7 +80,6 @@
latch.await();
}

@Ignore // RT-26710: javafx.scene.web.LeakTest hangs
This conversation was marked as resolved by arun-Joseph

This comment has been minimized.

Copy link
@kevinrushforth

kevinrushforth Nov 15, 2019

Member

RT-26710, aka JDK-8088139, is still listed as open. Since these tests no longer hang, can you close JDK-8088139 as "Cannot reproduce"?

@Test public void testGarbageCollectability() throws InterruptedException {
final BlockingQueue<WeakReference<WebPage>> webPageRefQueue =
new LinkedBlockingQueue<WeakReference<WebPage>>();
@@ -91,7 +91,6 @@
private static int dummyField;
}

@org.junit.Ignore
@Test public void testRT30835() throws Exception {
class Record {
private final Document document;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.