-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257512: Remove use of deprecated primitive constructors in JavaFX #423
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a couple problems (in code that we must not be building) noted below.
apps/samples/Ensemble8/src/samples/java/ensemble/samples/language/swing/SwingInterop.java
Outdated
Show resolved
Hide resolved
...s/javafx.graphics/src/test/jslc/com/sun/scenario/effect/compiler/parser/PrimaryExprTest.java
Outdated
Show resolved
Hide resolved
...les/javafx.graphics/src/test/jslc/com/sun/scenario/effect/compiler/parser/UnaryExprTest.java
Outdated
Show resolved
Hide resolved
This is a simple change, but it would be good to have a second pair of eyes on it. /reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments where I think autoboxing does the same work explicit boxing does. Unless I'm missing something, all these places can be simplified.
apps/samples/Ensemble8/src/app/java/ensemble/samplepage/PieChartDataVisualizer.java
Outdated
Show resolved
Hide resolved
modules/javafx.controls/src/test/java/test/javafx/scene/control/MenuBarTest.java
Outdated
Show resolved
Hide resolved
apps/samples/3DViewer/src/main/java/com/javafx/experiments/shape3d/SkinningMesh.java
Outdated
Show resolved
Hide resolved
apps/samples/Ensemble8/src/samples/java/ensemble/samples/language/swing/SampleTableModel.java
Show resolved
Hide resolved
modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
Show resolved
Hide resolved
modules/javafx.graphics/src/main/java/com/sun/prism/es2/X11GLFactory.java
Show resolved
Hide resolved
modules/javafx.graphics/src/main/java/com/sun/prism/j2d/J2DPipeline.java
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/javafx/scene/NodeTest.java
Outdated
Show resolved
Hide resolved
modules/javafx.web/src/ios/java/javafx/scene/web/JSONDecoder.java
Outdated
Show resolved
Hide resolved
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@arapte Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 92d6232. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The following primitive constructors were deprecated in JDK 9 and are deprecated for removal in JDK 16.
This change removes call to the primitive constructors with the
valueOf()
factory method of respective class.Calls like the following to create array get autoboxed so it does not require a change.
Double dArr[] = new Double[] {10.1, 20.2};
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/423/head:pull/423
$ git checkout pull/423