Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257512: Remove use of deprecated primitive constructors in JavaFX #423

Closed
wants to merge 5 commits into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Mar 10, 2021

The following primitive constructors were deprecated in JDK 9 and are deprecated for removal in JDK 16.

java.lang.Byte
java.lang.Short
java.lang.Integer
java.lang.Long
java.lang.Float
java.lang.Double
java.lang.Character
java.lang.Boolean

This change removes call to the primitive constructors with the valueOf() factory method of respective class.
Calls like the following to create array get autoboxed so it does not require a change.

Double dArr[] = new Double[] {10.1, 20.2};


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257512: Remove use of deprecated primitive constructors in JavaFX

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/423/head:pull/423
$ git checkout pull/423

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 10, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good with a couple problems (in code that we must not be building) noted below.

@kevinrushforth
Copy link
Member

kevinrushforth commented Mar 10, 2021

This is a simple change, but it would be good to have a second pair of eyes on it.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Mar 10, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Collaborator

@nlisker nlisker left a comment

I left some comments where I think autoboxing does the same work explicit boxing does. Unless I'm missing something, all these places can be simplified.

@openjdk
Copy link

openjdk bot commented Mar 11, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257512: Remove use of deprecated primitive constructors in JavaFX

Reviewed-by: kcr, nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1473ea9: 8206253: No/Wrong scroll events from touch input in window mode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 11, 2021
@arapte
Copy link
Member Author

arapte commented Mar 12, 2021

/integrate

@openjdk openjdk bot closed this Mar 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 12, 2021
@openjdk
Copy link

openjdk bot commented Mar 12, 2021

@arapte Since your change was applied there has been 1 commit pushed to the master branch:

  • 1473ea9: 8206253: No/Wrong scroll events from touch input in window mode

Your commit was automatically rebased without conflicts.

Pushed as commit 92d6232.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the rem_deprecated_ctrs branch May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants