Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264061: LocalDateTimeStringConverterTest fails in Canada #438

Closed
wants to merge 1 commit into from

Conversation

@jgneff
Copy link
Member

@jgneff jgneff commented Mar 23, 2021

As the comment in the test case mentions, "Tests require that default locale is en_US." The default locale is required by the objects created in the static method implementations, marked with the JUnit annotation @Parameterized.Parameters. So the static method initDefaultLocale, marked with the JUnit annotation @BeforeClass, calls the method to set the required default: Locale.setDefault(Locale.US).

The problem occurs because the @Parameterized.Parameters method is called before the @BeforeClass method, so the system locale is used as the default instead of Locale.US.

The fix is to move the call to the first instruction of the @Parameterized.Parameters method so that the default is set before it's required.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264061: LocalDateTimeStringConverterTest fails in Canada

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/438/head:pull/438
$ git checkout pull/438

To update a local copy of the PR:
$ git checkout pull/438
$ git pull https://git.openjdk.java.net/jfx pull/438/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 23, 2021

👋 Welcome back jgneff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Ah, I hadn't realized that. So this is a correction to the earlier fix for JDK-8160039.

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@jgneff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264061: LocalDateTimeStringConverterTest fails in Canada

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 73e70fe: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 23, 2021
@jgneff
Copy link
Member Author

@jgneff jgneff commented Mar 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@jgneff
Your change (at version c3e843e) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@kevinrushforth @jgneff Since your change was applied there has been 1 commit pushed to the master branch:

  • 73e70fe: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

Your commit was automatically rebased without conflicts.

Pushed as commit 3bbcf97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jgneff jgneff deleted the blame-canada branch Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants