-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264061: LocalDateTimeStringConverterTest fails in Canada #438
Conversation
👋 Welcome back jgneff! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I hadn't realized that. So this is a correction to the earlier fix for JDK-8160039.
Looks good.
@jgneff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@kevinrushforth @jgneff Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 3bbcf97. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As the comment in the test case mentions, "Tests require that default locale is en_US." The default locale is required by the objects created in the static method
implementations
, marked with the JUnit annotation@Parameterized.Parameters
. So the static methodinitDefaultLocale
, marked with the JUnit annotation@BeforeClass
, calls the method to set the required default:Locale.setDefault(Locale.US)
.The problem occurs because the
@Parameterized.Parameters
method is called before the@BeforeClass
method, so the system locale is used as the default instead ofLocale.US
.The fix is to move the call to the first instruction of the
@Parameterized.Parameters
method so that the default is set before it's required.Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/438/head:pull/438
$ git checkout pull/438
To update a local copy of the PR:
$ git checkout pull/438
$ git pull https://git.openjdk.java.net/jfx pull/438/head