Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211362: Restrict export of libjpeg symbols from libjavafx_iio.so #442

Closed
wants to merge 2 commits into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Mar 25, 2021

Fix for JDK-8211362

Compile javafx-iio native files with -f-visibiliy=hidden in order
not to export the non-JNI symbols.
Although this issue was about libjavafx_iio.so only (and not about libjavafx_iio.a), this PR allows fixing the static build as well.

For static builds, we also use ld -r to build a static library, so that objcopy or similar can be used to remove the names of the
hidden symbols.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8211362: Restrict export of libjpeg symbols from libjavafx_iio.so

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/442/head:pull/442
$ git checkout pull/442

To update a local copy of the PR:
$ git checkout pull/442
$ git pull https://git.openjdk.java.net/jfx pull/442/head

Compile javafx-iio native files with -f-visibiliy=hidden in order
not to export the non-JNI symbols.
For static builds, we also use ld -r to build a static library,
so that objcopy or similar can be used to remove the names of the
hidden symbols.
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2021

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Mar 25, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Test build passed. I confirmed that the internal jpeg symbols are now hidden.

@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8211362: Restrict export of libjpeg symbols from libjavafx_iio.so

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Mar 25, 2021
@johanvos
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Mar 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Mar 25, 2021
@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@johanvos Pushed as commit ed5cfe7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants