8264330: Scene MouseHandler is referencing removed nodes

[hjohn]

Small fix to clear a reference to a removed node left by Scene$MouseHandler.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264330: Scene MouseHandler is referencing removed nodes

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/448/head:pull/448
$ git checkout pull/448

Update a local copy of the PR:
$ git checkout pull/448
$ git pull https://git.openjdk.java.net/jfx pull/448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 448

View PR using the GUI difftool:
$ git pr show -t 448

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/448.diff

[bridgekeeper]

👋 Welcome back jhendrikx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full - Incremental (0be3b899)
• 01: Full - Incremental (371ede22)
• 00: Full (26cdfe1f)

[kevinrushforth]

The fix looks good to me. I haven't run the test yet, but it seems OK except for the handling of GC to check for the leak (I left an inline comment).

[kevinrushforth]

Oh, I thought that javafx.graphics already referenced it. The following should be sufficient:

--- a/build.gradle
+++ b/build.gradle
@@ -2089,6 +2089,7 @@ project(":graphics") {
         stubCompile group: "junit", name: "junit", version: "4.8.2"

         antlr group: "org.antlr", name: "antlr4", version: "4.7.2", classifier: "complete"
+        testCompile project(":base").sourceSets.test.output
         compile project(':base')
     }

[kevinrushforth]

Did you find that it worked without the addition of the dependency to build.gradle? You didn't commit that change. I guess we'll see what the GitHub actions build shows.

[hjohn]

Did you find that it worked without the addition of the dependency to build.gradle? You didn't commit that change. I guess we'll see what the GitHub actions build shows.

I forgot to add the change I did in build.gradle, it didn't work without it :)

[kevinrushforth]

Looks good. I confirm that the new test fails without your fix and passes with your fix.

[openjdk]

@hjohn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264330: Scene MouseHandler is referencing removed nodes

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• eec2f39: 8264536: Building OpenJFX on Apple AARCH64 not possible
• f3e27a0: 8264162: PickResult.toString() is missing the closing square bracket
• d80b8ad: 8264501: UIWebView for iOS is deprecated
• ed5cfe7: 8211362: Restrict export of libjpeg symbols from libjavafx_iio.so
• 3bbcf97: 8264061: LocalDateTimeStringConverterTest fails in Canada
• 73e70fe: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop
• d4d57fb: 8263778: Fix monocle JNI signatures for instance methods

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[hjohn]

/integrate

[openjdk]

@hjohn
Your change (at version 0be3b89) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

@kevinrushforth @hjohn Since your change was applied there have been 7 commits pushed to the master branch:

• eec2f39: 8264536: Building OpenJFX on Apple AARCH64 not possible
• f3e27a0: 8264162: PickResult.toString() is missing the closing square bracket
• d80b8ad: 8264501: UIWebView for iOS is deprecated
• ed5cfe7: 8211362: Restrict export of libjpeg symbols from libjavafx_iio.so
• 3bbcf97: 8264061: LocalDateTimeStringConverterTest fails in Canada
• 73e70fe: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop
• d4d57fb: 8263778: Fix monocle JNI signatures for instance methods

Your commit was automatically rebased without conflicts.

Pushed as commit 015dad0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.