Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234056: Upgrade to libxslt 1.1.34 #45

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Contributor

arun-Joseph commented Nov 18, 2019

We need to update the version of libxslt to the latest version, 1.1.34.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8234056: Upgrade to libxslt 1.1.34

Approvers

  • Kevin Rushforth (kcr - Reviewer)
  • Johan Vos (jvos - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2019

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 18, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2019

Webrevs

Copy link
Member

kevinrushforth left a comment

Looks good. This will need a second reviewer.

@openjdk openjdk bot removed the rfr label Nov 20, 2019
@openjdk
Copy link

openjdk bot commented Nov 20, 2019

@arun-Joseph This change can now be integrated. The commit message will be:

8234056: Upgrade to libxslt 1.1.34

Reviewed-by: kcr, jvos
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 6 commits pushed to the master branch:

  • 8bea7b7: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors
  • aad1720: 8233420: Upgrade to gcc 8.3 on Linux
  • 42040c4: 8232063: Upgrade gradle to version 6.0
  • aab07a4: 8234239: [TEST_BUG] Reenable few ignored web tests
  • 95ad601: 8233421: Upgrade to Visual Studio 2017 version 15.9.16
  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @johanvos) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@openjdk openjdk bot added the ready label Nov 20, 2019
@openjdk openjdk deleted a comment from mlbridge bot Nov 20, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2019

Mailing list message from amnojeeuw on openjfx-dev:

Hello folks!How can I remove myself from this mailing list?Thank in advance.Sent from my Samsung Galaxy smartphone.
-------- Original message --------From: Kevin Rushforth Date: 2019-11-20 9:07 AM (GMT-05:00) To: openjfx-dev at openjdk.java.net Subject: Re: [Approved] RFR: 8234056: Upgrade to libxslt 1.1.34 On Mon, 18 Nov 2019 13:29:32 GMT, Arun Joseph wrote:> We need to update the version of libxslt to the latest version, 1.1.34.> > ----------------> > Commits:>? - 2d9c0bf: 8234056: Upgrade to libxslt 1.1.34> > Changes: https://git.openjdk.java.net/jfx/pull/45/files>? Webrev: https://webrevs.openjdk.java.net/jfx/45/webrev.00>?? Issue: https://bugs.openjdk.java.net/browse/JDK-8234056>?? Stats: 868 lines in 34 files changed: 419 ins; 263 del; 186 mod>?? Patch: https://git.openjdk.java.net/jfx/pull/45.diff>?? Fetch: git fetch https://git.openjdk.java.net/jfx pull/45/head:pull/45Looks good. This will need a second reviewer.----------------Approved by kcr (Lead).PR: https://git.openjdk.java.net/jfx/pull/45

Copy link
Collaborator

johanvos left a comment

Builds and sanity checks passed on Linux/Mac/Win

@arun-Joseph
Copy link
Contributor Author

arun-Joseph commented Nov 21, 2019

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2019

@arun-Joseph
Your change (at version 2d9c0bf) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Nov 21, 2019
@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 21, 2019

/sponsor

@openjdk openjdk bot closed this Nov 21, 2019
@openjdk openjdk bot added integrated and removed sponsor labels Nov 21, 2019
@openjdk
Copy link

openjdk bot commented Nov 21, 2019

@kevinrushforth @arun-Joseph The following commits have been pushed to master since your change was applied:

  • 8bea7b7: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors
  • aad1720: 8233420: Upgrade to gcc 8.3 on Linux
  • 42040c4: 8232063: Upgrade gradle to version 6.0
  • aab07a4: 8234239: [TEST_BUG] Reenable few ignored web tests
  • 95ad601: 8233421: Upgrade to Visual Studio 2017 version 15.9.16
  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests

Your commit was automatically rebased without conflicts.

Pushed as commit 5a39824.

@openjdk openjdk bot removed the ready label Nov 21, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2019

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: 5a39824
Author: Arun Joseph
Committer: Kevin Rushforth
Date: 2019-11-21 14:17:35 +0000
URL: https://git.openjdk.java.net/jfx/commit/5a398244

8234056: Upgrade to libxslt 1.1.34

Reviewed-by: kcr, jvos

! modules/javafx.web/src/main/legal/libxslt.md
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/linux/config.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/linux/libexslt/exsltconfig.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/linux/libxslt/xsltwin32config.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/mac/config.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/Makefile.am
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/config.h.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/configure.ac
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libexslt.pc.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt.pc.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt.spec
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt.spec.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/Makefile.am
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/attrvt.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/functions.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/keys.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/libxslt.syms
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/numbers.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/pattern.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/pattern.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/security.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/templates.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/transform.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/variables.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/xslt.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/xsltInternals.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/xsltconfig.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/xsltconfig.h.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/xsltutils.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/xsltutils.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/win32/Makefile.mingw
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/win32/Makefile.msvc
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/win32/libxslt.def.src
! modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/xsltConf.sh.in

@arun-Joseph arun-Joseph deleted the arun-Joseph:8234056 branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.