Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259555: Webkit crashes on Apple Silicon #452

Closed
wants to merge 1 commit into from

Conversation

arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Apr 2, 2021

WebKit crashes during JavaScriptCore initialization code for Apple Silicon.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Contributors

  • Peter Zhelezniakov <peterz@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/452/head:pull/452
$ git checkout pull/452

Update a local copy of the PR:
$ git checkout pull/452
$ git pull https://git.openjdk.java.net/jfx pull/452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 452

View PR using the GUI difftool:
$ git pr show -t 452

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/452.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2021

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@arun-Joseph
Copy link
Member Author

arun-Joseph commented Apr 2, 2021

/contributor add @petermz

@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@arun-Joseph
Contributor Peter Zhelezniakov <peterz@openjdk.org> successfully added.

@arun-Joseph arun-Joseph marked this pull request as ready for review Apr 2, 2021
@openjdk openjdk bot added the rfr Ready for review label Apr 2, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2021

Webrevs

@johanvos
Copy link
Collaborator

johanvos commented Apr 2, 2021

This works, as long as MACOSX_MIN_VERSION is set to 11. I guess we don't want to commit that in the build.gradle, as we only require that for a build on Apple Silicon.

@johanvos johanvos self-requested a review Apr 2, 2021
@kevinrushforth kevinrushforth self-requested a review Apr 2, 2021
@kevinrushforth
Copy link
Member

kevinrushforth commented Apr 2, 2021

/reviewers 2

@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

kevinrushforth commented Apr 2, 2021

Any changes to minimum OS version in mac.gradle would need to be qualified by a check for the target architecture. It might make sense to do that in connection with other needed build changes.

Copy link
Collaborator

@johanvos johanvos left a comment

The other required changes required to build for M1 can easily be passed as build parameters using gradlew -P
Hence, this change contains all that is needed to be changed in the repository.

@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@arun-Joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259555: Webkit crashes on Apple Silicon

Co-authored-by: Peter Zhelezniakov <peterz@openjdk.org>
Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 052e9f7: 8258381: [macos] Exception when input emoji using Chinese input method

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Apr 2, 2021
@arun-Joseph
Copy link
Member Author

arun-Joseph commented Apr 2, 2021

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Apr 2, 2021
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@arun-Joseph Since your change was applied there has been 1 commit pushed to the master branch:

  • 052e9f7: 8258381: [macos] Exception when input emoji using Chinese input method

Your commit was automatically rebased without conflicts.

Pushed as commit b2f842d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arun-Joseph arun-Joseph deleted the 8259555 branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants