8137323: Incorrect parsing of mnemonic in controls text #453
This PR fixes incorrect parsing of mnemonic symbols in the following cases:
As a side effect, this PR also fixes another undocumented issue for multiline text where text metrics calculations incorrectly operate on text for which mnemonic symbols have not been processed.
This can lead to a glitch where the mnemonic underscore makes a text just long enough to wrap to a new line, but when the text is rendered, the second line shows up entirely empty. The reason for this is that for rendering, the text is laid out after mnemonic symbols have been removed.
The solution is to always use processed text ("clean text") when laying out text.
The text was updated successfully, but these errors were encountered:
This looks good to me, although I have never used extended mnemonics, so don't know how to test them. The rest is fine (and the visual display of the extended mnemonics is fine as long as elided the parenthesized char is the right thing to do). I also verified that the new tests fail without the fix and pass with the fix.
@mstr2 This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 45 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas, @kevinrushforth) but any other Committer may sponsor as well.
Your commit was automatically rebased without conflicts.
Pushed as commit affb108.