Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259356: MediaPlayer's seek freezes video #464

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Apr 17, 2021

This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS streams (unfortunately I was not able to find repro case and more details on why it was added) in gstappsink.c line 659-678 to store current caps which can be lost during seek/flush. However, this workaround broke code in gst_app_sink_render_common() line 939 which was restoring caps if they were flushed, since we set last_caps to non NULL value. Since code in gst_app_sink_render_common() did not work to propagate caps to sample our rendering code was dropping frames without caps. Fixed by setting caps on sample in HLS workaround code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/464/head:pull/464
$ git checkout pull/464

Update a local copy of the PR:
$ git checkout pull/464
$ git pull https://git.openjdk.java.net/jfx pull/464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 464

View PR using the GUI difftool:
$ git pr show -t 464

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/464.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 17, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 17, 2021

Webrevs

@johanvos johanvos self-requested a review Apr 17, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 17, 2021

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review Apr 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I verified on both macOS and Windows that the seek problem is now fixed.

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 17, 2021

Verified on Linux and MacOS, looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259356: MediaPlayer's seek freezes video

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8e54757: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.
  • 05ab799: 8208088: Memory Leak in ControlAcceleratorSupport

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 17, 2021
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Apr 19, 2021

/integrate

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@sashamatveev Since your change was applied there have been 3 commits pushed to the master branch:

  • 56f2e17: 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error
  • 8e54757: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling.
  • 05ab799: 8208088: Memory Leak in ControlAcceleratorSupport

Your commit was automatically rebased without conflicts.

Pushed as commit a683558.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants