Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234084: [TEST_BUG] Remove unexecuted performance benchmark tests #468

Closed
wants to merge 1 commit into from

Conversation

@arapte
Copy link
Member

@arapte arapte commented Apr 20, 2021

This PR removes two benchmark tests that are ignored since they were added here

test.javafx.scene.input.TouchEventTest.saneOrderingBenchmark
test.javafx.scene.input.TouchEventTest.crazyOrderingBenchmark

Since the tests do not compare but only print the time taken by programmatically generating the touch events and
are not executed since the time they were added, It seems reasonable to remove them.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8234084: [TEST_BUG] Remove unexecuted performance benchmark tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/468/head:pull/468
$ git checkout pull/468

Update a local copy of the PR:
$ git checkout pull/468
$ git pull https://git.openjdk.java.net/jfx pull/468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 468

View PR using the GUI difftool:
$ git pr show -t 468

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/468.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 20, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 20, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8234084: [TEST_BUG] Remove unexecuted performance benchmark tests

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 20, 2021
@arapte
Copy link
Member Author

@arapte arapte commented Apr 21, 2021

/integrate

@openjdk openjdk bot closed this Apr 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@arapte Since your change was applied there have been 3 commits pushed to the master branch:

  • 49d2126: 8263788: JavaFX application freezes completely after some time when using the WebView
  • 67828ae: 8261840: Submenus close to screen borders are no longer repositioned
  • af75a1f: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest

Your commit was automatically rebased without conflicts.

Pushed as commit 8f0062d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants