8265513: Openjfx graphics build broken (Eclipse)

[kleopatra]

Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in JDK-8264330.

Fix is to add-exports in Eclipse .classpath in graphics (same as done for controls in fix of JDK-8256184

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265513: Openjfx graphics build broken (Eclipse)

Reviewers

• Nir Lisker (@nlisker - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/469/head:pull/469
$ git checkout pull/469

Update a local copy of the PR:
$ git checkout pull/469
$ git pull https://git.openjdk.java.net/jfx pull/469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 469

View PR using the GUI difftool:
$ git pr show -t 469

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/469.diff

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (0844fdab)

[kevinrushforth]

@nlisker Since you are an Eclipse user, can you review this?

[kevinrushforth]

(it looks obviously correct to me)

[nlisker]

Looks correct, but will take me some time to actually test it.

[nlisker]

I can confirm that the access error to JMemoryBuddy is resolved after the patch.

[openjdk]

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265513: Openjfx graphics build broken (Eclipse)

Reviewed-by: nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 27e57d3: 8265469: Allow to build media and webkit for Linux-AArch64
• dfda00d: 8265514: Openjfx controls running tests broken (Eclipse)
• 1b407cc: 8239880: CSS tests should cleanup any global state they modify
• fab638a: 8265425: Hard failure when building OpenJFX for Linux AArch64
• dffdc6f: 8265758: [TestBug] Remove ignored unit test from CustomMenuItemTest
• 4a9c892: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64)
• 86b854d: 8234077: Evaluate ignored unit tests in RenderRootTest
• 8f0062d: 8234084: [TEST_BUG] Remove unexecuted performance benchmark tests
• 49d2126: 8263788: JavaFX application freezes completely after some time when using the WebView
• 67828ae: 8261840: Submenus close to screen borders are no longer repositioned
• ... and 3 more: https://git.openjdk.java.net/jfx/compare/56f2e17f3bb4cdc2392e40ef17b7405f95a4d66d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

@kleopatra Since your change was applied there have been 14 commits pushed to the master branch:

• b50ce94: 8264952: [TestBug] Controls unit tests - ControlTest and SpinnerTest fail for non US Locale
• 27e57d3: 8265469: Allow to build media and webkit for Linux-AArch64
• dfda00d: 8265514: Openjfx controls running tests broken (Eclipse)
• 1b407cc: 8239880: CSS tests should cleanup any global state they modify
• fab638a: 8265425: Hard failure when building OpenJFX for Linux AArch64
• dffdc6f: 8265758: [TestBug] Remove ignored unit test from CustomMenuItemTest
• 4a9c892: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64)
• 86b854d: 8234077: Evaluate ignored unit tests in RenderRootTest
• 8f0062d: 8234084: [TEST_BUG] Remove unexecuted performance benchmark tests
• 49d2126: 8263788: JavaFX application freezes completely after some time when using the WebView
• ... and 4 more: https://git.openjdk.java.net/jfx/compare/56f2e17f3bb4cdc2392e40ef17b7405f95a4d66d...master

Your commit was automatically rebased without conflicts.

Pushed as commit db30e71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.