Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute #47
Issue: Native part of WebView throws a DOMException and then, continues executing the rest of the function assuming that value is present. This causes the JVM to crash when retrieving the value.
Fix: Return from the function if exception was raised (code is similar to exception handling in WebKitLegacy/java/DOM/JavaTreeWalker.cpp)
This fix also needs to be applied to all function calls in WebKitLegacy/java/DOM functions which raises DOMError similar to createAttributeImpl().
JDK-8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
kevinrushforth left a comment
I can confirm that this fixes the problem. The test case attached to the bug and the new unit test you added fail (crash) without your fix and throw the expected exception with your fix.
I don't quite understand your earlier comment about needing to change the caller when the type is
I added a comment about formatting (missing spaces around a
This will need a second reviewer, so I request @guruhb to review.
@arun-Joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 29 commits pushed to the
As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @guruhb) but any other Committer may sponsor as well.
Your commit was automatically rebased without conflicts.
Pushed as commit f1108b0.
8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
Reviewed-by: kcr, ghb