-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8210199: [linux / macOS] fileChooser can't handle emojis #471
Conversation
👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
I ran this on both MacOS and Linux. The fix looks fine and solves the issue. I do not see the exception with the fix. I tested on MacOs 10.15.7 and Ubuntu 20.10 and Ubuntu 20.04. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce the problem Pankaj reported on Linux, and can confirm that it is unrelated to FileChooser. It looks like some sort of deadlock that happens when calling java.awt.Desktop::open
from the event handler. I'll file a separate bug for that.
I modified the test program to call Files.readString(file.toPath())
instead, and can confirm that the fix works on Linux as well as on macOS.
@jperedadnr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I filed JDK-8267572 to track the hang on Linux. |
/integrate |
@jperedadnr Since your change was applied there have been 42 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit aebac07. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Both
GlassDialogs.m
for macOS andGlassCommonDialogs.c
for Linux use UTF8 encoding for the file names selected via native FileChooser, and this will fail if there are emojis in the file name.This PR uses the same approach as in JDK-8258381 for macOS, using UTF16 encoding.
For Linux, the Java
String(byte[] bytes)
constructor with default charset is used instead, preventing the need of using UTF8 encoding.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/471/head:pull/471
$ git checkout pull/471
Update a local copy of the PR:
$ git checkout pull/471
$ git pull https://git.openjdk.java.net/jfx pull/471/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 471
View PR using the GUI difftool:
$ git pr show -t 471
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/471.diff