Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265514: Openjfx controls running tests broken (Eclipse) #472

Closed
wants to merge 2 commits into from

Conversation

@arapte
Copy link
Member

@arapte arapte commented Apr 21, 2021

As mentioned in JBS the unit test execution fails when tests have a duplicate package name.
This was introduced by JDK-8204568: it created a test in a new package test.javafx.css in controls tests. A similar package already existed in graphics unit tests.
This is a simple fix to rename the package. Test is moved to existing package in controls test under test.javafx.scene.control


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265514: Openjfx controls running tests broken (Eclipse)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/472/head:pull/472
$ git checkout pull/472

Update a local copy of the PR:
$ git checkout pull/472
$ git pull https://git.openjdk.java.net/jfx pull/472/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 472

View PR using the GUI difftool:
$ git pr show -t 472

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/472.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 21, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 21, 2021

Webrevs

package test.javafx.scene.control;

Copy link
Collaborator

@kleopatra kleopatra Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh .. you moved the test into an existing package - that's fine with me if you are certain that we don't want a dedicated package for css? Locally, I create test.javafx.scene.control.css and moved the tests there. But really doesn't matter much :)

Copy link
Member Author

@arapte arapte Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package test.javafx.scene.control.css sounds good to me too. It is changed now.

Copy link
Collaborator

@kleopatra kleopatra left a comment

looks good :)

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265514: Openjfx controls running tests broken (Eclipse)

Reviewed-by: fastegal, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4a9c892: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 22, 2021
@arapte
Copy link
Member Author

@arapte arapte commented Apr 23, 2021

/integrate

@openjdk openjdk bot closed this Apr 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@arapte Since your change was applied there have been 4 commits pushed to the master branch:

  • 1b407cc: 8239880: CSS tests should cleanup any global state they modify
  • fab638a: 8265425: Hard failure when building OpenJFX for Linux AArch64
  • dffdc6f: 8265758: [TestBug] Remove ignored unit test from CustomMenuItemTest
  • 4a9c892: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64)

Your commit was automatically rebased without conflicts.

Pushed as commit dfda00d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants