Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265399: Update to Visual Studio 2019 version 16.9.3 #482

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 27, 2021

This patch updates the compiler to Visual Studio 2019 version 16.9.3 on Windows, in order to match JDK 17 -- see JDK-8265371.

I ran a full build and test, including media and WebKit.

NOTE: I also have PR #481 out for review to update the Linux gcc compiler. I intend to integrate that one first, at which time I will need to merge master into this branch to resolve a trivial merge conflict (the changes are on adjacent lines).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265399: Update to Visual Studio 2019 version 16.9.3

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/482/head:pull/482
$ git checkout pull/482

Update a local copy of the PR:
$ git checkout pull/482
$ git pull https://git.openjdk.java.net/jfx pull/482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 482

View PR using the GUI difftool:
$ git pr show -t 482

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/482.diff

@kevinrushforth kevinrushforth requested review from johanvos, tiainen and arapte Apr 27, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 27, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 27, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 27, 2021

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@arapte
arapte approved these changes Apr 28, 2021
Copy link
Member

@arapte arapte left a comment

Builds successfully on windows.

@arapte
arapte approved these changes Apr 29, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 30, 2021

Pending review from @johanvos or @tiainen

@tiainen
Copy link
Collaborator

@tiainen tiainen commented Apr 30, 2021

I'll run a test on our build infrastructure.

@kevinrushforth kevinrushforth mentioned this pull request Apr 30, 2021
3 of 3 tasks complete
Copy link
Collaborator

@tiainen tiainen left a comment

The build and tests ran fine.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 30, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265399: Update to Visual Studio 2019 version 16.9.3

Reviewed-by: arapte, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • affb108: 8137323: Incorrect parsing of mnemonic in controls text

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 30, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 30, 2021

/integrate

@openjdk openjdk bot closed this Apr 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 30, 2021

@kevinrushforth Since your change was applied there has been 1 commit pushed to the master branch:

  • affb108: 8137323: Incorrect parsing of mnemonic in controls text

Your commit was automatically rebased without conflicts.

Pushed as commit 7ec132c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8265399-vs2019-16.9.3 branch May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants