Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8186904: TableColumnHeader: resize cursor lost on right click #483

Conversation

@Maran23
Copy link
Member

@Maran23 Maran23 commented Apr 28, 2021

This PR is fixing a bug, when a right click on a table column is performed.
By doing that, the table columns will lose the resize cursor thus they can not be resized anymore.

The reason for that is that the columnDragLock will not reset (to false).
This flag is set to true, when a mouse press is detected (on a table column) and to false, when a mouse release is detected. Unfortunately, this flag is not reset on a right click, because a check (#isPopupTrigger()) will guard against it.

With this PR, this flag will always reset to false inside the mouse released handler.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8186904: TableColumnHeader: resize cursor lost on right click

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/483/head:pull/483
$ git checkout pull/483

Update a local copy of the PR:
$ git checkout pull/483
$ git pull https://git.openjdk.java.net/jfx pull/483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 483

View PR using the GUI difftool:
$ git pr show -t 483

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/483.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 28, 2021

👋 Welcome back Maran23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 28, 2021

Webrevs

@kevinrushforth kevinrushforth requested a review from aghaisas May 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8186904: TableColumnHeader: resize cursor lost on right click

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 9c97d9b: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
  • f236a7d: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem
  • 285a0b6: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing
  • 8ca7815: 8267160: Monocle mouse never get ENTERED state
  • 9e8c617: 8266516: One label typo in the properties for bi-directional text
  • 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
  • e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)
  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86
  • eb913cb: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed
  • ... and 10 more: https://git.openjdk.java.net/jfx/compare/cc70cdf19f0069cd485571231f89cf5939c7602f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 17, 2021
@Maran23
Copy link
Member Author

@Maran23 Maran23 commented May 17, 2021

/integrate

@openjdk openjdk bot added the sponsor label May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@Maran23
Your change (at version 2c3e5da) is now ready to be sponsored by a Committer.

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented May 18, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@aghaisas @Maran23 Since your change was applied there have been 24 commits pushed to the master branch:

  • 4619cdd: 8264138: Replace uses of Class.newInstance
  • 93de584: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568
  • c511789: 8266860: [macos] Incorrect duration reported for HLS live streams
  • d2d145d: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test
  • 9c97d9b: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
  • f236a7d: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem
  • 285a0b6: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing
  • 8ca7815: 8267160: Monocle mouse never get ENTERED state
  • 9e8c617: 8266516: One label typo in the properties for bi-directional text
  • 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
  • ... and 14 more: https://git.openjdk.java.net/jfx/compare/cc70cdf19f0069cd485571231f89cf5939c7602f...master

Your commit was automatically rebased without conflicts.

Pushed as commit e76b7b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Maran23 Maran23 deleted the 8186904-resize-cursor-lost-on-right-click branch Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants