Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264157: Items of non-editable ComboBox cannot be selected using up/down keys #485

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented May 4, 2021

This issue JDK-8264157 is a regression of JDK-8209788, which removed two KeyMappings from ComboBoxListViewBehavior. That removal was not required to fix JDK-8209788.
Reverting ComboBoxListViewBehavior.java fixes the regression.
Fix includes a new test which fails before and pass with the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264157: Items of non-editable ComboBox cannot be selected using up/down keys

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/485/head:pull/485
$ git checkout pull/485

Update a local copy of the PR:
$ git checkout pull/485
$ git pull https://git.openjdk.java.net/jfx pull/485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 485

View PR using the GUI difftool:
$ git pr show -t 485

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/485.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label May 4, 2021
@mlbridge
Copy link

mlbridge bot commented May 4, 2021

Webrevs

Copy link
Collaborator

@kleopatra kleopatra left a comment

fix looks good, verified test failing before and passing after - crossing fingers we got it completely right this time :)

@openjdk
Copy link

openjdk bot commented May 6, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264157: Items of non-editable ComboBox cannot be selected using up/down keys

Reviewed-by: fastegal, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 6, 2021
@arapte
Copy link
Member Author

arapte commented May 6, 2021

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@arapte Since your change was applied there has been 1 commit pushed to the master branch:

  • 599ca1e: 8265277: SkinBase::registerChangeListener​ missing '@SInCE 9' javadoc tag

Your commit was automatically rebased without conflicts.

Pushed as commit 4b6c587.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the ComboBoxBehavior_regression branch May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants