Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265277: SkinBase::registerChangeListener​ missing '@since 9' javadoc tag #487

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented May 6, 2021

Please review a very simple fix that adds a missing javadoc tag.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/487/head:pull/487
$ git checkout pull/487

Update a local copy of the PR:
$ git checkout pull/487
$ git pull https://git.openjdk.java.net/jfx pull/487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 487

View PR using the GUI difftool:
$ git pr show -t 487

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/487.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 6, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Unrelated to your change, I see the following failure in the GitHub Actions test run on Linux:

2021-05-06T10:27:19.6546656Z test.javafx.css.HonorDeveloperSettingsTest > testOpacityWithManuallyChangedValueAndInlineStyleIsSetToInlineStyle FAILED
2021-05-06T10:27:19.6549284Z     java.lang.NullPointerException
2021-05-06T10:27:19.6550829Z         at javafx.graphics/javafx.scene.Node.notifyParentsOfInvalidatedCSS(Node.java:9295)
2021-05-06T10:27:19.6552527Z         at javafx.graphics/javafx.scene.Node.reapplyCSS(Node.java:9342)
2021-05-06T10:27:19.6553757Z         at javafx.graphics/javafx.scene.Node$1.reapplyCSS(Node.java:588)
2021-05-06T10:27:19.6555253Z         at javafx.graphics/com.sun.javafx.scene.NodeHelper.reapplyCSS(NodeHelper.java:283)
2021-05-06T10:27:19.6557553Z         at javafx.graphics/com.sun.javafx.css.StyleManager.userAgentStylesheetsChanged(StyleManager.java:1514)
2021-05-06T10:27:19.6560309Z         at javafx.graphics/com.sun.javafx.css.StyleManager.setDefaultUserAgentStylesheet(StyleManager.java:1365)
2021-05-06T10:27:19.6563106Z         at javafx.graphics/com.sun.javafx.css.StyleManager.setDefaultUserAgentStylesheet(StyleManager.java:1347)
2021-05-06T10:27:19.6571692Z         at test.javafx.css.HonorDeveloperSettingsTest.setUp(HonorDeveloperSettingsTest.java:89)

Can you file a new bug for this intermittent failure?

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265277: SkinBase::registerChangeListener​ missing '@since 9' javadoc tag

Reviewed-by: kcr, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 6, 2021
@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented May 6, 2021

Can you file a new bug for this intermittent failure?

I have filed JDK-8266643 for this.

@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented May 6, 2021

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@aghaisas Pushed as commit 599ca1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aghaisas aghaisas deleted the add_since_9_tag branch Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants