New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265277: SkinBase::registerChangeListener missing '@since 9' javadoc tag #487
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Unrelated to your change, I see the following failure in the GitHub Actions test run on Linux:
2021-05-06T10:27:19.6546656Z test.javafx.css.HonorDeveloperSettingsTest > testOpacityWithManuallyChangedValueAndInlineStyleIsSetToInlineStyle FAILED
2021-05-06T10:27:19.6549284Z java.lang.NullPointerException
2021-05-06T10:27:19.6550829Z at javafx.graphics/javafx.scene.Node.notifyParentsOfInvalidatedCSS(Node.java:9295)
2021-05-06T10:27:19.6552527Z at javafx.graphics/javafx.scene.Node.reapplyCSS(Node.java:9342)
2021-05-06T10:27:19.6553757Z at javafx.graphics/javafx.scene.Node$1.reapplyCSS(Node.java:588)
2021-05-06T10:27:19.6555253Z at javafx.graphics/com.sun.javafx.scene.NodeHelper.reapplyCSS(NodeHelper.java:283)
2021-05-06T10:27:19.6557553Z at javafx.graphics/com.sun.javafx.css.StyleManager.userAgentStylesheetsChanged(StyleManager.java:1514)
2021-05-06T10:27:19.6560309Z at javafx.graphics/com.sun.javafx.css.StyleManager.setDefaultUserAgentStylesheet(StyleManager.java:1365)
2021-05-06T10:27:19.6563106Z at javafx.graphics/com.sun.javafx.css.StyleManager.setDefaultUserAgentStylesheet(StyleManager.java:1347)
2021-05-06T10:27:19.6571692Z at test.javafx.css.HonorDeveloperSettingsTest.setUp(HonorDeveloperSettingsTest.java:89)
Can you file a new bug for this intermittent failure?
@aghaisas This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
I have filed JDK-8266643 for this. |
/integrate |
Please review a very simple fix that adds a missing javadoc tag.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/487/head:pull/487
$ git checkout pull/487
Update a local copy of the PR:
$ git checkout pull/487
$ git pull https://git.openjdk.java.net/jfx pull/487/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 487
View PR using the GUI difftool:
$ git pr show -t 487
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/487.diff