Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264219: tools/scripts/build.ps1 is out of date and no longer works #490

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 8, 2021

As noted in PR #212 the unused tools/scripts/build.ps1 script no longer works. This script was added in support of the Appveyor builds in the old javafxports/openjdk-jfx sandbox repo, which haven't been used in nearly two years. In its current state, it is more harmful to leave it in, as it is a source of confusion. Since the script is unused, this PR will simply delete it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264219: tools/scripts/build.ps1 is out of date and no longer works

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/490/head:pull/490
$ git checkout pull/490

Update a local copy of the PR:
$ git checkout pull/490
$ git pull https://git.openjdk.java.net/jfx pull/490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 490

View PR using the GUI difftool:
$ git pr show -t 490

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/490.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 8, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 8, 2021

Webrevs

Copy link
Collaborator

@pankaj-bansal pankaj-bansal left a comment

looks good to me

arapte
arapte approved these changes May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264219: tools/scripts/build.ps1 is out of date and no longer works

Reviewed-by: pbansal, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • e76b7b1: 8186904: TableColumnHeader: resize cursor lost on right click
  • 4619cdd: 8264138: Replace uses of Class.newInstance
  • 93de584: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568
  • c511789: 8266860: [macos] Incorrect duration reported for HLS live streams
  • d2d145d: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test
  • 9c97d9b: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
  • f236a7d: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem
  • 285a0b6: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing
  • 8ca7815: 8267160: Monocle mouse never get ENTERED state
  • 9e8c617: 8266516: One label typo in the properties for bi-directional text
  • ... and 5 more: https://git.openjdk.java.net/jfx/compare/ab7c15159d840377e6ceb9a80dd62e074aa80301...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 18, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 18, 2021

/integrate

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@kevinrushforth Since your change was applied there have been 15 commits pushed to the master branch:

  • e76b7b1: 8186904: TableColumnHeader: resize cursor lost on right click
  • 4619cdd: 8264138: Replace uses of Class.newInstance
  • 93de584: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568
  • c511789: 8266860: [macos] Incorrect duration reported for HLS live streams
  • d2d145d: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test
  • 9c97d9b: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
  • f236a7d: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem
  • 285a0b6: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing
  • 8ca7815: 8267160: Monocle mouse never get ENTERED state
  • 9e8c617: 8266516: One label typo in the properties for bi-directional text
  • ... and 5 more: https://git.openjdk.java.net/jfx/compare/ab7c15159d840377e6ceb9a80dd62e074aa80301...master

Your commit was automatically rebased without conflicts.

Pushed as commit 485b242.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8264219-rm-build.ps1 branch May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants