Skip to content

8264138: Replace uses of Class.newInstance #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aghaisas wants to merge 4 commits into from
Closed

8264138: Replace uses of Class.newInstance #491

aghaisas wants to merge 4 commits into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented May 10, 2021 •
edited by openjdk bot
Loading

This PR replaces Class.newInstance() deprecated method with Contructor.newinstance().

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/491/head:pull/491
$ git checkout pull/491

Update a local copy of the PR:
$ git checkout pull/491
$ git pull https://git.openjdk.java.net/jfx pull/491/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 491

View PR using the GUI difftool:
$ git pr show -t 491

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/491.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label May 10, 2021
@mlbridge
Copy link

mlbridge bot commented May 10, 2021 •
edited
Loading

Webrevs

@aghaisas
Copy link
Collaborator Author

aghaisas commented May 12, 2021

Found and replaced deprecated Class.newInstance() instances in apps and unit tests.

@kevinrushforth kevinrushforth self-requested a review May 12, 2021 20:02
kevinrushforth
kevinrushforth reviewed May 12, 2021
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments (in tests), where the replacement code isn't equivalent.

modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java
throw constructLoadException(exception);
value = type.getDeclaredConstructor().newInstance();
} catch (Exception e) {
throw constructLoadException(e);
Copy link
Member

@kevinrushforth kevinrushforth May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite equivalent, since it will now wrap a RuntimeException in a LoadException, but I think that's OK in this case.

@openjdk
Copy link

openjdk bot commented May 13, 2021 •
edited
Loading

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264138: Replace uses of Class.newInstance

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
  • e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)
  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86
  • eb913cb: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 13, 2021
@aghaisas
Copy link
Collaborator Author

aghaisas commented May 18, 2021

/integrate

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels May 18, 2021
@openjdk
Copy link

openjdk bot commented May 18, 2021

@aghaisas Since your change was applied there have been 13 commits pushed to the master branch:

  • 93de584: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568
  • c511789: 8266860: [macos] Incorrect duration reported for HLS live streams
  • d2d145d: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test
  • 9c97d9b: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
  • f236a7d: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem
  • 285a0b6: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing
  • 8ca7815: 8267160: Monocle mouse never get ENTERED state
  • 9e8c617: 8266516: One label typo in the properties for bi-directional text
  • 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
  • e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)
  • ... and 3 more: https://git.openjdk.java.net/jfx/compare/ab7c15159d840377e6ceb9a80dd62e074aa80301...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4619cdd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aghaisas aghaisas deleted the replace_deprecated_newInstance branch July 19, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinrushforth kevinrushforth kevinrushforth approved these changes

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aghaisas @kevinrushforth