Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266811: Openjfx controls test build broken (Eclipse) #493

Closed
wants to merge 1 commit into from

Conversation

kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented May 11, 2021

was introduced with fix JDK-8189354 which uses MockListObserver in tests. Fix is analogous to previous eclipse build problems (f.i. JDK-8265513): add-exports to allow access to base' test package.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266811: Openjfx controls test build broken (Eclipse)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/493/head:pull/493
$ git checkout pull/493

Update a local copy of the PR:
$ git checkout pull/493
$ git pull https://git.openjdk.java.net/jfx pull/493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 493

View PR using the GUI difftool:
$ git pr show -t 493

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/493.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 12, 2021

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266811: Openjfx controls test build broken (Eclipse)

Reviewed-by: nlisker

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 12, 2021
@kleopatra
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this May 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels May 12, 2021
@openjdk
Copy link

openjdk bot commented May 12, 2021

@kleopatra Since your change was applied there have been 2 commits pushed to the master branch:

  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86

Your commit was automatically rebased without conflicts.

Pushed as commit e40b0b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kleopatra kleopatra deleted the bug-fix-8266811 branch September 3, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants