Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266860: [macos] Incorrect duration reported for HLS live streams #495

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented May 11, 2021

For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number double value) and our code expects -1.0. Based on doc we should be using CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed by using CMTIME_IS_INDEFINITE to test if duration is indefinite and if true -1.0 will be return to our Java layer.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266860: [macos] Incorrect duration reported for HLS live streams

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/495/head:pull/495
$ git checkout pull/495

Update a local copy of the PR:
$ git checkout pull/495
$ git pull https://git.openjdk.java.net/jfx pull/495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 495

View PR using the GUI difftool:
$ git pr show -t 495

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/495.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 11, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 11, 2021

Webrevs

Loading

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 12, 2021

/reviewers 2

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Loading

@kevinrushforth kevinrushforth self-requested a review May 12, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 15, 2021

I requested 2 reviewers before I reviewed the fix, since changes in media are usually complex enough that a second reviewer is needed. In this case the fix is simple and obvious, so I don't think a second reviewer is required.

@sashamatveev I recommend to wait until later in the day Monday to integrate this in case anyone else wants to take a look.

/reviewers 1

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 1.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266860: [macos] Incorrect duration reported for HLS live streams

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 8ca7815: 8267160: Monocle mouse never get ENTERED state
  • 9e8c617: 8266516: One label typo in the properties for bi-directional text
  • 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
  • e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)
  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 15, 2021
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented May 18, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@sashamatveev Since your change was applied there have been 10 commits pushed to the master branch:

  • d2d145d: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test
  • 9c97d9b: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
  • f236a7d: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem
  • 285a0b6: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing
  • 8ca7815: 8267160: Monocle mouse never get ENTERED state
  • 9e8c617: 8266516: One label typo in the properties for bi-directional text
  • 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
  • e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)
  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86

Your commit was automatically rebased without conflicts.

Pushed as commit c511789.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants