Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest #497

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented May 12, 2021

The system test test.com.sun.webkit.LocalStorageAccessTest fails on Windows as mentioned in JDK-8265661. We should skip this test until it is fixed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/497/head:pull/497
$ git checkout pull/497

Update a local copy of the PR:
$ git checkout pull/497
$ git pull https://git.openjdk.java.net/jfx pull/497/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 497

View PR using the GUI difftool:
$ git pr show -t 497

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/497.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 12, 2021

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@arun-Joseph arun-Joseph marked this pull request as ready for review May 12, 2021
@openjdk openjdk bot added the rfr label May 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 12, 2021

Webrevs

@kevinrushforth kevinrushforth self-requested a review May 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@arun-Joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86
  • eb913cb: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 12, 2021
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented May 13, 2021

/integrate

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@arun-Joseph Since your change was applied there have been 4 commits pushed to the master branch:

  • e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)
  • c7833f1: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml
  • 3ac6bf0: 8266919: Gradle verification fails on windows x86
  • eb913cb: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed

Your commit was automatically rebased without conflicts.

Pushed as commit 389e8c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arun-Joseph arun-Joseph deleted the 8266968 branch May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants