8267121: Illegal access to private "size" field of ArrayList from build.gradle

[kevinrushforth]

A test of our CI build with gradle 7.0.1 and JDK 16.0.1 revealed a latent bug in build.gradle in the fetchExternalTools() method. It checks the size of an ArrayList in two places, but rather than calling the size() method it omits the () which means it is accessing the private size field.

Starting in JDK 16, which has default strong encapsulation, this no longer works, so we need to fix this before switching. We really should fix it anyway, since accessing the internal field is both unnecessary and wrong.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267121: Illegal access to private "size" field of ArrayList from build.gradle

Reviewers

• Ambarish Rapte (@arapte - Reviewer)
• Johan Vos (@johanvos - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/503/head:pull/503
$ git checkout pull/503

Update a local copy of the PR:
$ git checkout pull/503
$ git pull https://git.openjdk.java.net/jfx pull/503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 503

View PR using the GUI difftool:
$ git pr show -t 503

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/503.diff

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (0fd69580)

[arapte]

lgtm, Did not find any other instance where size member variable is used.

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267121: Illegal access to private "size" field of ArrayList from build.gradle

Reviewed-by: arapte, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 8ca7815: 8267160: Monocle mouse never get ENTERED state
• 9e8c617: 8266516: One label typo in the properties for bi-directional text
• 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
• e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[johanvos]

looks good.

[kevinrushforth]

/integrate

[openjdk]

@kevinrushforth Since your change was applied there have been 6 commits pushed to the master branch:

• f236a7d: 8266539: [TreeView]: Change.getRemoved() contains null item when deselecting a TreeItem
• 285a0b6: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing
• 8ca7815: 8267160: Monocle mouse never get ENTERED state
• 9e8c617: 8266516: One label typo in the properties for bi-directional text
• 389e8c0: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest
• e40b0b8: 8266811: Openjfx controls test build broken (Eclipse)

Your commit was automatically rebased without conflicts.

Pushed as commit 9c97d9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.