Skip to content

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 19, 2021

This PR updates the boot JDK for JavaFX builds to use JDK 16.0.1. The minimum version of the JDK remains unchanged at JDK 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/507/head:pull/507
$ git checkout pull/507

Update a local copy of the PR:
$ git checkout pull/507
$ git pull https://git.openjdk.java.net/jfx pull/507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 507

View PR using the GUI difftool:
$ git pr show -t 507

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/507.diff

@kevinrushforth
Copy link
Member Author

/reviewers 2

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label May 19, 2021
@openjdk
Copy link

openjdk bot commented May 19, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

mlbridge bot commented May 19, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

It looks like we are still seeing occasional failures in HonorDeveloperSettingsTest on Linux. I filed JDK-8267425 to track this.

@arapte
Copy link
Member

arapte commented May 20, 2021

Linux build failure is not related to this change,
failed test: test.javafx.css.HonorDeveloperSettingsTest > testOpacityWithManuallyChangedValueAndInlineStyleIsSetToInlineStyle FAILED
Looks like the fix of #496 is not sufficient.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and test ran successfully on windows, mac and linux.

Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@openjdk
Copy link

openjdk bot commented May 23, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263761: Update boot JDK to 16.0.1

Reviewed-by: arapte, sykora, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • aebac07: 8210199: [linux / macOS] fileChooser can't handle emojis
  • 240d28f: 8264127: ListCell editing status is true, when index changes while editing
  • 5843910: 8267392: ENTER key press on editable TableView throws NPE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 23, 2021
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels May 24, 2021
@openjdk
Copy link

openjdk bot commented May 24, 2021

@kevinrushforth Since your change was applied there have been 3 commits pushed to the master branch:

  • aebac07: 8210199: [linux / macOS] fileChooser can't handle emojis
  • 240d28f: 8264127: ListCell editing status is true, when index changes while editing
  • 5843910: 8267392: ENTER key press on editable TableView throws NPE

Your commit was automatically rebased without conflicts.

Pushed as commit 2fd5092.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8263761-bootjdk-16.0.1 branch June 1, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants