-
Notifications
You must be signed in to change notification settings - Fork 562
8263761: Update boot JDK to 16.0.1 #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263761: Update boot JDK to 16.0.1 #507
Conversation
|
/reviewers 2 |
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
@kevinrushforth |
|
It looks like we are still seeing occasional failures in |
|
Linux build failure is not related to this change, |
tiainen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build and test ran successfully on windows, mac and linux.
johanvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@kevinrushforth Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2fd5092. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR updates the boot JDK for JavaFX builds to use JDK 16.0.1. The minimum version of the JDK remains unchanged at JDK 11.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/507/head:pull/507$ git checkout pull/507Update a local copy of the PR:
$ git checkout pull/507$ git pull https://git.openjdk.java.net/jfx pull/507/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 507View PR using the GUI difftool:
$ git pr show -t 507Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/507.diff